From: Jeff Garzik <jeff@garzik.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linux-ide@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, tj@kernel.org
Subject: Re: [PATCH 4/5] libata/sff: Use ops->bmdma_stop instead of ata_bmdma_stop()
Date: Thu, 03 Dec 2009 02:35:51 -0500 [thread overview]
Message-ID: <4B176A57.5040605@garzik.org> (raw)
In-Reply-To: <20091202003629.4342710080C@ozlabs.org>
On 12/01/2009 07:36 PM, Benjamin Herrenschmidt wrote:
> In libata-sff, ata_sff_post_internal_cmd() directly calls ata_bmdma_stop()
> instead of ap->ops->bmdma_stop(). This can be a problem for controllers
> that use their own bmdma_stop for which the generic sff one isn't suitable
>
> Signed-off-by: Benjamin Herrenschmidt<benh@kernel.crashing.org>
> ---
>
> drivers/ata/libata-sff.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-work.orig/drivers/ata/libata-sff.c 2009-12-01 17:48:27.000000000 +1100
> +++ linux-work/drivers/ata/libata-sff.c 2009-12-01 17:48:48.000000000 +1100
> @@ -2384,7 +2384,7 @@ void ata_sff_post_internal_cmd(struct at
> ap->hsm_task_state = HSM_ST_IDLE;
>
> if (ap->ioaddr.bmdma_addr)
> - ata_bmdma_stop(qc);
> + ap->ops->bmdma_stop(qc);
>
> spin_unlock_irqrestore(ap->lock, flags);
applied
As we discussed, feel free to carry this in your tree as well. git
should be able to sort it out.
Acked-by: Jeff Garzik <jgarzik@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Garzik <jeff@garzik.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: tj@kernel.org, linux-ide@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 4/5] libata/sff: Use ops->bmdma_stop instead of ata_bmdma_stop()
Date: Thu, 03 Dec 2009 02:35:51 -0500 [thread overview]
Message-ID: <4B176A57.5040605@garzik.org> (raw)
In-Reply-To: <20091202003629.4342710080C@ozlabs.org>
On 12/01/2009 07:36 PM, Benjamin Herrenschmidt wrote:
> In libata-sff, ata_sff_post_internal_cmd() directly calls ata_bmdma_stop()
> instead of ap->ops->bmdma_stop(). This can be a problem for controllers
> that use their own bmdma_stop for which the generic sff one isn't suitable
>
> Signed-off-by: Benjamin Herrenschmidt<benh@kernel.crashing.org>
> ---
>
> drivers/ata/libata-sff.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-work.orig/drivers/ata/libata-sff.c 2009-12-01 17:48:27.000000000 +1100
> +++ linux-work/drivers/ata/libata-sff.c 2009-12-01 17:48:48.000000000 +1100
> @@ -2384,7 +2384,7 @@ void ata_sff_post_internal_cmd(struct at
> ap->hsm_task_state = HSM_ST_IDLE;
>
> if (ap->ioaddr.bmdma_addr)
> - ata_bmdma_stop(qc);
> + ap->ops->bmdma_stop(qc);
>
> spin_unlock_irqrestore(ap->lock, flags);
applied
As we discussed, feel free to carry this in your tree as well. git
should be able to sort it out.
Acked-by: Jeff Garzik <jgarzik@redhat.com>
next prev parent reply other threads:[~2009-12-03 7:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-02 0:36 [PATCH 4/5] libata/sff: Use ops->bmdma_stop instead of ata_bmdma_stop() Benjamin Herrenschmidt
2009-12-02 0:36 ` Benjamin Herrenschmidt
2009-12-03 7:35 ` Jeff Garzik [this message]
2009-12-03 7:35 ` Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2009-12-01 7:08 Benjamin Herrenschmidt
2009-12-01 7:08 ` Benjamin Herrenschmidt
2009-12-01 7:25 ` Tejun Heo
2009-12-01 7:29 ` Benjamin Herrenschmidt
2009-12-01 7:33 ` Tejun Heo
2009-12-01 7:57 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B176A57.5040605@garzik.org \
--to=jeff@garzik.org \
--cc=benh@kernel.crashing.org \
--cc=linux-ide@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.