From: Avi Kivity <avi@redhat.com>
To: Avishay Traeger1 <AVISHAY@il.ibm.com>
Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org,
Rusty Russell <rusty@rustcorp.com.au>,
virtualization <virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH] virtio spec: add virtio-blk max sectors feature
Date: Thu, 03 Dec 2009 11:58:38 +0200 [thread overview]
Message-ID: <4B178BCE.7030003@redhat.com> (raw)
In-Reply-To: <OF38B713F7.02DD66D1-ONC2257681.002F3CAD-C2257681.002FDEA6@il.ibm.com>
On 12/03/2009 10:42 AM, Avishay Traeger1 wrote:
> I previously submitted a patch to have the guest virtio-blk driver get the
> value for the maximum I/O size from the host bdrv, rather than assume that
> there is no limit. Avi requested that I first patch the virtio spec
> (http://ozlabs.org/~rusty/virtio-spec/). Below is that patch.
>
> Please CC me on replies, as I am not subscribed.
>
>
Copying Rusty and virtualization@.
> Thank you,
> Avishay
>
> Signed-off-by: Avishay Traeger<avishay@il.ibm.com>
>
> --- virtio-spec-0.8.2.lyx 2009-11-30 16:34:16.000000000 +0200
> +++ virtio-spec-0.8.2-mod.lyx 2009-12-01 16:04:36.000000000 +0200
> @@ -3999,6 +3999,20 @@
> \end_inset
>
> .
> +\change_inserted 0 1259672174
> +
> +\end_layout
> +
> +\begin_layout Description
> +
> +\change_inserted 0 1259672252
> +VIRTIO_BLK_F_SECTOR_MAX
> +\begin_inset space ~
> +\end_inset
> +
> +(10) Maximum sectors in an I/O.
> +\change_unchanged
> +
> \end_layout
>
> \end_deeper
> @@ -4068,6 +4082,17 @@
> \begin_layout Plain Layout
>
> u32 blk_size;
> +\change_inserted 0 1259672274
> +
> +\end_layout
> +
> +\begin_layout Plain Layout
> +
> +\change_inserted 0 1259672305
> +
> + u32 sectors_max;
> +\change_unchanged
> +
> \end_layout
>
> \begin_layout Plain Layout
> @@ -4107,6 +4132,18 @@
> \begin_layout Enumerate
> If the VIRTIO_BLK_F_RO feature is set by the device, any write requests
> will fail.
> +\change_inserted 0 1259672345
> +
> +\end_layout
> +
> +\begin_layout Enumerate
> +
> +\change_inserted 0 1259672454
> +If the VIRTIO_BLK_F_SECTOR_MAX feature is negotiated, the sectors_max
> field
> + should be read to determine the maximum I/O size for the driver to use.
> + No requests should be submitted which go beyond this limit.
> +\change_unchanged
> +
> \end_layout
>
> \begin_layout Section*
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
error compiling committee.c: too many arguments to function
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: Avishay Traeger1 <AVISHAY@il.ibm.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
qemu-devel@nongnu.org, kvm@vger.kernel.org,
virtualization <virtualization@lists.linux-foundation.org>
Subject: [Qemu-devel] Re: [PATCH] virtio spec: add virtio-blk max sectors feature
Date: Thu, 03 Dec 2009 11:58:38 +0200 [thread overview]
Message-ID: <4B178BCE.7030003@redhat.com> (raw)
In-Reply-To: <OF38B713F7.02DD66D1-ONC2257681.002F3CAD-C2257681.002FDEA6@il.ibm.com>
On 12/03/2009 10:42 AM, Avishay Traeger1 wrote:
> I previously submitted a patch to have the guest virtio-blk driver get the
> value for the maximum I/O size from the host bdrv, rather than assume that
> there is no limit. Avi requested that I first patch the virtio spec
> (http://ozlabs.org/~rusty/virtio-spec/). Below is that patch.
>
> Please CC me on replies, as I am not subscribed.
>
>
Copying Rusty and virtualization@.
> Thank you,
> Avishay
>
> Signed-off-by: Avishay Traeger<avishay@il.ibm.com>
>
> --- virtio-spec-0.8.2.lyx 2009-11-30 16:34:16.000000000 +0200
> +++ virtio-spec-0.8.2-mod.lyx 2009-12-01 16:04:36.000000000 +0200
> @@ -3999,6 +3999,20 @@
> \end_inset
>
> .
> +\change_inserted 0 1259672174
> +
> +\end_layout
> +
> +\begin_layout Description
> +
> +\change_inserted 0 1259672252
> +VIRTIO_BLK_F_SECTOR_MAX
> +\begin_inset space ~
> +\end_inset
> +
> +(10) Maximum sectors in an I/O.
> +\change_unchanged
> +
> \end_layout
>
> \end_deeper
> @@ -4068,6 +4082,17 @@
> \begin_layout Plain Layout
>
> u32 blk_size;
> +\change_inserted 0 1259672274
> +
> +\end_layout
> +
> +\begin_layout Plain Layout
> +
> +\change_inserted 0 1259672305
> +
> + u32 sectors_max;
> +\change_unchanged
> +
> \end_layout
>
> \begin_layout Plain Layout
> @@ -4107,6 +4132,18 @@
> \begin_layout Enumerate
> If the VIRTIO_BLK_F_RO feature is set by the device, any write requests
> will fail.
> +\change_inserted 0 1259672345
> +
> +\end_layout
> +
> +\begin_layout Enumerate
> +
> +\change_inserted 0 1259672454
> +If the VIRTIO_BLK_F_SECTOR_MAX feature is negotiated, the sectors_max
> field
> + should be read to determine the maximum I/O size for the driver to use.
> + No requests should be submitted which go beyond this limit.
> +\change_unchanged
> +
> \end_layout
>
> \begin_layout Section*
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-12-03 9:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-03 8:42 [PATCH] virtio spec: add virtio-blk max sectors feature Avishay Traeger1
2009-12-03 8:42 ` [Qemu-devel] " Avishay Traeger1
2009-12-03 9:58 ` Avi Kivity
2009-12-03 9:58 ` Avi Kivity [this message]
2009-12-03 9:58 ` [Qemu-devel] " Avi Kivity
2009-12-08 5:48 ` Rusty Russell
2009-12-08 5:48 ` Rusty Russell
2009-12-08 5:48 ` [Qemu-devel] " Rusty Russell
2009-12-08 9:44 ` Avishay Traeger1
2009-12-08 9:44 ` Avishay Traeger1
2009-12-08 9:44 ` [Qemu-devel] " Avishay Traeger1
2009-12-08 9:50 ` Avi Kivity
2009-12-08 9:50 ` [Qemu-devel] " Avi Kivity
2009-12-08 9:50 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B178BCE.7030003@redhat.com \
--to=avi@redhat.com \
--cc=AVISHAY@il.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.