[Ocfs2-devel] [PATCH] ocfs2: explicit declare uninitialized var in user_cluster_connect()

[Ocfs2-devel] [PATCH] ocfs2: explicit declare uninitialized var in user_cluster_connect()

[Coly Li]

This patch explicitly declares an uninitialized local variable in user_cluster_connect(), to remove a compiling warning.

Signed-off-by: Coly Li <coly.li@suse.de>
---
 fs/ocfs2/stack_user.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/ocfs2/stack_user.c b/fs/ocfs2/stack_user.c
index ff4c798..da78a2a 100644
--- a/fs/ocfs2/stack_user.c
+++ b/fs/ocfs2/stack_user.c
@@ -814,7 +814,7 @@ static int fs_protocol_compare(struct ocfs2_protocol_version *existing,
 static int user_cluster_connect(struct ocfs2_cluster_connection *conn)
 {
 	dlm_lockspace_t *fsdlm;
-	struct ocfs2_live_connection *control;
+	struct ocfs2_live_connection *uninitialized_var(control);
 	int rc = 0;

 	BUG_ON(conn == NULL);
-- 
Coly Li
SuSE Labs

[Ocfs2-devel] [PATCH] ocfs2: explicit declare uninitialized var in user_cluster_connect()

[Joel Becker]

On Fri, Dec 04, 2009 at 02:02:35AM +0800, Coly Li wrote:
> This patch explicitly declares an uninitialized local variable in user_cluster_connect(), to remove a compiling warning.

	This is now in the 'merge-window' branch of ocfs2.git.

Joel

-- 

"Can any of you seriously say the Bill of Rights could get through
 Congress today?  It wouldn't even get out of committee."
	- F. Lee Bailey

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127