* [PATCH] tty: PTR_ERR return of wrong pointer in fs3270_open()
@ 2009-12-07 13:33 Roel Kluin
2009-12-07 14:03 ` Martin Schwidefsky
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2009-12-07 13:33 UTC (permalink / raw)
To: Martin Schwidefsky, Andrew Morton, LKML
Return the PTR_ERR of the correct pointer.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
drivers/s390/char/fs3270.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/s390/char/fs3270.c b/drivers/s390/char/fs3270.c
index 097d384..2ae58d0 100644
--- a/drivers/s390/char/fs3270.c
+++ b/drivers/s390/char/fs3270.c
@@ -465,7 +465,7 @@ fs3270_open(struct inode *inode, struct file *filp)
if (IS_ERR(ib)) {
raw3270_put_view(&fp->view);
raw3270_del_view(&fp->view);
- rc = PTR_ERR(fp);
+ rc = PTR_ERR(ib);
goto out;
}
fp->rdbuf = ib;
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] tty: PTR_ERR return of wrong pointer in fs3270_open()
2009-12-07 13:33 [PATCH] tty: PTR_ERR return of wrong pointer in fs3270_open() Roel Kluin
@ 2009-12-07 14:03 ` Martin Schwidefsky
0 siblings, 0 replies; 2+ messages in thread
From: Martin Schwidefsky @ 2009-12-07 14:03 UTC (permalink / raw)
To: Roel Kluin; +Cc: Andrew Morton, LKML
On Mon, 07 Dec 2009 14:33:39 +0100
Roel Kluin <roel.kluin@gmail.com> wrote:
> Return the PTR_ERR of the correct pointer.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> drivers/s390/char/fs3270.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/s390/char/fs3270.c b/drivers/s390/char/fs3270.c
> index 097d384..2ae58d0 100644
> --- a/drivers/s390/char/fs3270.c
> +++ b/drivers/s390/char/fs3270.c
> @@ -465,7 +465,7 @@ fs3270_open(struct inode *inode, struct file *filp)
> if (IS_ERR(ib)) {
> raw3270_put_view(&fp->view);
> raw3270_del_view(&fp->view);
> - rc = PTR_ERR(fp);
> + rc = PTR_ERR(ib);
> goto out;
> }
> fp->rdbuf = ib;
And added this one as well.
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-12-07 14:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-07 13:33 [PATCH] tty: PTR_ERR return of wrong pointer in fs3270_open() Roel Kluin
2009-12-07 14:03 ` Martin Schwidefsky
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.