From: Jan Kiszka <jan.kiszka@siemens.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-devel <qemu-devel@nongnu.org>,
kvm <kvm@vger.kernel.org>
Subject: Re: Endless loop in qcow2_alloc_cluster_offset
Date: Mon, 07 Dec 2009 15:50:00 +0100 [thread overview]
Message-ID: <4B1D1618.2080900@siemens.com> (raw)
In-Reply-To: <4B1D0E34.6070907@siemens.com>
Jan Kiszka wrote:
> And now it happened again (qemu-kvm head, during kernel installation
> from network onto local qcow2-disk). Any clever idea how to proceed with
> this?
>
> I could try to run the step in a loop, hopefully retriggering it once in
> a (likely longer) while. But then we need some good instrumentation first.
>
Maybe I'm seeing ghosts, and I don't even have a minimal clue about what
goes on in the code, but this looks fishy:
preallocate() invokes qcow2_alloc_cluster_offset() passing &meta, a
stack variable. It seems that qcow2_alloc_cluster_offset() may insert
this structure into cluster_allocs and leave it there. So we corrupt the
queue as soon as preallocate() returns, no?
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
WARNING: multiple messages have this Message-ID (diff)
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-devel <qemu-devel@nongnu.org>,
kvm <kvm@vger.kernel.org>
Subject: [Qemu-devel] Re: Endless loop in qcow2_alloc_cluster_offset
Date: Mon, 07 Dec 2009 15:50:00 +0100 [thread overview]
Message-ID: <4B1D1618.2080900@siemens.com> (raw)
In-Reply-To: <4B1D0E34.6070907@siemens.com>
Jan Kiszka wrote:
> And now it happened again (qemu-kvm head, during kernel installation
> from network onto local qcow2-disk). Any clever idea how to proceed with
> this?
>
> I could try to run the step in a loop, hopefully retriggering it once in
> a (likely longer) while. But then we need some good instrumentation first.
>
Maybe I'm seeing ghosts, and I don't even have a minimal clue about what
goes on in the code, but this looks fishy:
preallocate() invokes qcow2_alloc_cluster_offset() passing &meta, a
stack variable. It seems that qcow2_alloc_cluster_offset() may insert
this structure into cluster_allocs and leave it there. So we corrupt the
queue as soon as preallocate() returns, no?
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2009-12-07 14:50 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-19 12:19 Endless loop in qcow2_alloc_cluster_offset Jan Kiszka
2009-11-19 12:19 ` [Qemu-devel] " Jan Kiszka
2009-11-19 14:49 ` Kevin Wolf
2009-11-19 14:49 ` [Qemu-devel] " Kevin Wolf
2009-11-19 14:58 ` Jan Kiszka
2009-11-19 14:58 ` [Qemu-devel] " Jan Kiszka
2009-12-07 14:16 ` Jan Kiszka
2009-12-07 14:16 ` [Qemu-devel] " Jan Kiszka
2009-12-07 14:50 ` Jan Kiszka [this message]
2009-12-07 14:50 ` Jan Kiszka
2009-12-07 15:03 ` Kevin Wolf
2009-12-07 15:03 ` [Qemu-devel] " Kevin Wolf
2009-12-07 15:25 ` Jan Kiszka
2009-12-07 15:25 ` [Qemu-devel] " Jan Kiszka
2009-12-07 15:04 ` Avi Kivity
2009-12-07 15:04 ` [Qemu-devel] " Avi Kivity
2009-12-07 15:00 ` Kevin Wolf
2009-12-07 15:00 ` [Qemu-devel] " Kevin Wolf
2009-12-07 16:09 ` Jan Kiszka
2009-12-07 16:09 ` [Qemu-devel] " Jan Kiszka
2009-12-07 16:26 ` Kevin Wolf
2009-12-07 16:26 ` [Qemu-devel] " Kevin Wolf
2009-12-08 14:51 ` Kevin Wolf
2010-05-07 1:19 ` Marcelo Tosatti
2010-05-07 1:19 ` [Qemu-devel] " Marcelo Tosatti
2010-05-07 7:37 ` Kevin Wolf
2010-05-07 7:37 ` [Qemu-devel] " Kevin Wolf
2010-05-07 15:16 ` Marcelo Tosatti
2010-05-07 15:16 ` [Qemu-devel] " Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B1D1618.2080900@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.