Re: Build failures on Ubuntu due to gettext

["Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1374 bytes --]

Colin Watson wrote:
> Furthermore, the style I suggested is used in many other GNU projects.
> Here are just a few examples:
>
>   coreutils/src/du.c:994:       error (0, 0, "%s", _("invalid zero-length file name"));
>   diffutils/src/sdiff.c:853:  fprintf (stderr, "%s", _("\
>   diffutils/src/sdiff.c-854-ed:\tEdit then use both versions, each decorated with a header.\n\
>   glibc/inet/rcmd.c:178:                              __fxprintf(NULL, "%s", _("\
>   glibc/inet/rcmd.c-179-rcmd: socket: All ports in use\n"));
>   gnulib/lib/xalloc-die.c:34:  error (exit_failure, 0, "%s", _("memory exhausted"));
>
>   
I have nothing against defining grub_putl_ (str); equivalent to
grub_printf ("%s\n", str); (defined as function if it's used extensively
for space reasons).
Just from your previous mails it seemed that you proposed to transform
strings like
grub_printf (_("Moving file %s to %s."), f1, f2); to grub_printf ("%s %s
%s %s.", _("Moving file"), f1, _("to"), f2);
to avoid translating format-strings which would be completely
untranslatable.
> Indeed, here's a commit from the gettext author using this style:
>
>   http://git.savannah.gnu.org/cgit/gettext.git/commit/?id=d5d1ae3b3c3ae2f837740e5f5d65326197ccdb98
>
> (Look for close_stdout_status in lib/closeout.c.)
>
>   


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 293 bytes --]