All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Jan Beulich <JBeulich@novell.com>,
	linux-kernel@vger.kernel.org, tony.luck@intel.com,
	linux-mm@kvack.org, linux-ia64@vger.kernel.org,
	Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH] mm/vmalloc: don't use vmalloc_end
Date: Tue, 08 Dec 2009 00:40:10 +0000	[thread overview]
Message-ID: <4B1DA06A.1050004@kernel.org> (raw)
In-Reply-To: <20091207153552.0fadf335.akpm@linux-foundation.org>

Hello,

On 12/08/2009 08:35 AM, Andrew Morton wrote:
> arch/m68k/include/asm/pgtable_mm.h does the same thing.  Did it break too?

Oh... m64k does the same thing.  I think the correct thing to do here
would be to convert arch code as in ia64.  I think defining
VMALLOC_END to vmalloc_end is a bit error-prone.  If it were defined
simply as vmalloc_end, it's unnoticeable by both the compiler and
developer.

Thanks.

-- 
tejun

WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Jan Beulich <JBeulich@novell.com>,
	linux-kernel@vger.kernel.org, tony.luck@intel.com,
	linux-mm@kvack.org, linux-ia64@vger.kernel.org,
	Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH] mm/vmalloc: don't use vmalloc_end
Date: Tue, 08 Dec 2009 09:40:10 +0900	[thread overview]
Message-ID: <4B1DA06A.1050004@kernel.org> (raw)
In-Reply-To: <20091207153552.0fadf335.akpm@linux-foundation.org>

Hello,

On 12/08/2009 08:35 AM, Andrew Morton wrote:
> arch/m68k/include/asm/pgtable_mm.h does the same thing.  Did it break too?

Oh... m64k does the same thing.  I think the correct thing to do here
would be to convert arch code as in ia64.  I think defining
VMALLOC_END to vmalloc_end is a bit error-prone.  If it were defined
simply as vmalloc_end, it's unnoticeable by both the compiler and
developer.

Thanks.

-- 
tejun

WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Jan Beulich <JBeulich@novell.com>,
	linux-kernel@vger.kernel.org, tony.luck@intel.com,
	linux-mm@kvack.org, linux-ia64@vger.kernel.org,
	Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH] mm/vmalloc: don't use vmalloc_end
Date: Tue, 08 Dec 2009 09:40:10 +0900	[thread overview]
Message-ID: <4B1DA06A.1050004@kernel.org> (raw)
In-Reply-To: <20091207153552.0fadf335.akpm@linux-foundation.org>

Hello,

On 12/08/2009 08:35 AM, Andrew Morton wrote:
> arch/m68k/include/asm/pgtable_mm.h does the same thing.  Did it break too?

Oh... m64k does the same thing.  I think the correct thing to do here
would be to convert arch code as in ia64.  I think defining
VMALLOC_END to vmalloc_end is a bit error-prone.  If it were defined
simply as vmalloc_end, it's unnoticeable by both the compiler and
developer.

Thanks.

-- 
tejun

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2009-12-08  0:40 UTC|newest]

Thread overview: 76+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-07 16:24 [PATCH] mm/vmalloc: don't use vmalloc_end Jan Beulich
2009-12-07 16:24 ` Jan Beulich
2009-12-07 23:35 ` Andrew Morton
2009-12-07 23:35   ` Andrew Morton
2009-12-07 23:35   ` Andrew Morton
2009-12-08  0:33   ` Tejun Heo
2009-12-08  0:33     ` Tejun Heo
2009-12-08  0:33     ` Tejun Heo
2009-12-08  0:40   ` Tejun Heo [this message]
2009-12-08  0:40     ` Tejun Heo
2009-12-08  0:40     ` Tejun Heo
2009-12-08  6:57     ` [PATCH] m68k: don't alias VMALLOC_END to vmalloc_end Tejun Heo
2009-12-08  6:57       ` Tejun Heo
2009-12-08  6:57       ` Tejun Heo
2009-12-08  9:08       ` Geert Uytterhoeven
2009-12-08  9:08         ` Geert Uytterhoeven
2009-12-08  9:08         ` Geert Uytterhoeven
2009-12-08  0:50   ` [PATCH] mm/vmalloc: don't use vmalloc_end Matthew Wilcox
2009-12-08  0:50     ` Matthew Wilcox
2009-12-08  0:50     ` Matthew Wilcox
2009-12-08  1:03     ` Andrew Morton
2009-12-08  1:03       ` Andrew Morton
2009-12-08  1:03       ` Andrew Morton
2009-12-08  8:23   ` Jan Beulich
2009-12-08  8:23     ` Jan Beulich
2009-12-08  8:23     ` Jan Beulich
2009-12-08  8:29     ` Tejun Heo
2009-12-08  8:29       ` Tejun Heo
2009-12-08  8:29       ` Tejun Heo
2009-12-08  8:39       ` Jan Beulich
2009-12-08  8:39         ` Jan Beulich
2009-12-08  8:57         ` Tejun Heo
2009-12-08  8:57           ` Tejun Heo
2009-12-08  8:57           ` Tejun Heo
2009-12-09 23:43           ` [PATCH -stable] vmalloc: conditionalize build of pcpu_get_vm_areas() Tejun Heo
2009-12-09 23:43             ` Tejun Heo
2009-12-09 23:43             ` Tejun Heo
2009-12-16 23:12             ` [stable] [PATCH -stable] vmalloc: conditionalize build of Greg KH
2009-12-16 23:12               ` [stable] [PATCH -stable] vmalloc: conditionalize build of pcpu_get_vm_areas() Greg KH
2009-12-16 23:12               ` Greg KH
2009-12-16 23:59               ` Tejun Heo
2009-12-17  0:01                 ` Tejun Heo
2009-12-17  0:01                 ` Tejun Heo
2009-12-17  0:02                 ` [stable] [PATCH -stable] vmalloc: conditionalize build of Greg KH
2009-12-17  0:02                   ` [stable] [PATCH -stable] vmalloc: conditionalize build of pcpu_get_vm_areas() Greg KH
2009-12-17  0:02                   ` Greg KH
2009-12-09 17:31     ` [PATCH] mm/vmalloc: don't use vmalloc_end Christoph Lameter
2009-12-09 17:31       ` Christoph Lameter
2009-12-09 17:31       ` Christoph Lameter
2009-12-09 17:48       ` Luck, Tony
2009-12-09 17:48         ` Luck, Tony
2009-12-09 17:48         ` Luck, Tony
2009-12-09 18:10       ` Mike Travis
2009-12-09 18:10         ` Mike Travis
2009-12-09 18:10         ` Mike Travis
2009-12-09 18:23         ` Christoph Lameter
2009-12-09 18:23           ` Christoph Lameter
2009-12-09 18:23           ` Christoph Lameter
2009-12-09 18:24           ` Christoph Lameter
2009-12-09 18:24             ` Christoph Lameter
2009-12-09 18:24             ` Christoph Lameter
2009-12-09 18:37           ` Mike Travis
2009-12-09 18:37             ` Mike Travis
2009-12-09 18:37             ` Mike Travis
2009-12-09 18:46             ` Christoph Lameter
2009-12-09 18:46               ` Christoph Lameter
2009-12-09 18:46               ` Christoph Lameter
2009-12-08  9:11   ` Geert Uytterhoeven
2009-12-08  9:11     ` Geert Uytterhoeven
2009-12-08  9:11     ` Geert Uytterhoeven
2009-12-08  9:24     ` Tejun Heo
2009-12-08  9:24       ` Tejun Heo
2009-12-08  9:24       ` Tejun Heo
2009-12-09  8:47       ` [PATCH] m68k: rename global variable vmalloc_end to m68k_vmalloc_end Tejun Heo
2009-12-09  8:47         ` Tejun Heo
2009-12-09  8:47         ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B1DA06A.1050004@kernel.org \
    --to=tj@kernel.org \
    --cc=JBeulich@novell.com \
    --cc=akpm@linux-foundation.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.