From: Rik van Riel <riel@redhat.com>
To: Minchan Kim <minchan.kim@gmail.com>
Cc: lwoodman@redhat.com, kosaki.motohiro@jp.fujitsu.com,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, aarcange@redhat.com
Subject: Re: [PATCH] vmscan: limit concurrent reclaimers in shrink_zone
Date: Fri, 11 Dec 2009 16:24:42 -0500 [thread overview]
Message-ID: <4B22B89A.3060009@redhat.com> (raw)
In-Reply-To: <28c262360912101803i7b43db78se8cf9ec61d92ee0f@mail.gmail.com>
On 12/10/2009 09:03 PM, Minchan Kim wrote:
> On Fri, Dec 11, 2009 at 8:56 AM, Rik van Riel<riel@redhat.com> wrote:
>> Under very heavy multi-process workloads, like AIM7, the VM can
>> get into trouble in a variety of ways. The trouble start when
>> there are hundreds, or even thousands of processes active in the
>> page reclaim code.
> Otherwise looks good to me.
>
> Reviewed-by: Minchan Kim<minchan.kim@gmail.com>
OK, we found three issues with my patch :)
1) there is a typo in sysctl.c
2) there is another typo in Documentation/vm/sysctl.c
3) the code in vmscan.c has a bug, where tasks without
__GFP_IO or __GFP_FS can end up waiting for tasks
with __GFP_IO or __GFP_FS, leading to a deadlock
I will fix these issues and send out a new patch.
--
All rights reversed.
WARNING: multiple messages have this Message-ID (diff)
From: Rik van Riel <riel@redhat.com>
To: Minchan Kim <minchan.kim@gmail.com>
Cc: lwoodman@redhat.com, kosaki.motohiro@jp.fujitsu.com,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, aarcange@redhat.com
Subject: Re: [PATCH] vmscan: limit concurrent reclaimers in shrink_zone
Date: Fri, 11 Dec 2009 16:24:42 -0500 [thread overview]
Message-ID: <4B22B89A.3060009@redhat.com> (raw)
In-Reply-To: <28c262360912101803i7b43db78se8cf9ec61d92ee0f@mail.gmail.com>
On 12/10/2009 09:03 PM, Minchan Kim wrote:
> On Fri, Dec 11, 2009 at 8:56 AM, Rik van Riel<riel@redhat.com> wrote:
>> Under very heavy multi-process workloads, like AIM7, the VM can
>> get into trouble in a variety of ways. The trouble start when
>> there are hundreds, or even thousands of processes active in the
>> page reclaim code.
> Otherwise looks good to me.
>
> Reviewed-by: Minchan Kim<minchan.kim@gmail.com>
OK, we found three issues with my patch :)
1) there is a typo in sysctl.c
2) there is another typo in Documentation/vm/sysctl.c
3) the code in vmscan.c has a bug, where tasks without
__GFP_IO or __GFP_FS can end up waiting for tasks
with __GFP_IO or __GFP_FS, leading to a deadlock
I will fix these issues and send out a new patch.
--
All rights reversed.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-12-11 21:25 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-10 23:56 [PATCH] vmscan: limit concurrent reclaimers in shrink_zone Rik van Riel
2009-12-10 23:56 ` Rik van Riel
2009-12-11 2:03 ` Minchan Kim
2009-12-11 2:03 ` Minchan Kim
2009-12-11 3:19 ` Rik van Riel
2009-12-11 3:19 ` Rik van Riel
2009-12-11 3:43 ` Minchan Kim
2009-12-11 3:43 ` Minchan Kim
2009-12-11 12:07 ` Larry Woodman
2009-12-11 12:07 ` Larry Woodman
2009-12-11 13:41 ` Minchan Kim
2009-12-11 13:41 ` Minchan Kim
2009-12-11 13:51 ` Rik van Riel
2009-12-11 13:51 ` Rik van Riel
2009-12-11 14:08 ` Minchan Kim
2009-12-11 14:08 ` Minchan Kim
2009-12-11 13:48 ` Rik van Riel
2009-12-11 13:48 ` Rik van Riel
2009-12-11 21:24 ` Rik van Riel [this message]
2009-12-11 21:24 ` Rik van Riel
2009-12-11 11:49 ` Larry Woodman
2009-12-11 11:49 ` Larry Woodman
2009-12-14 13:08 ` Andi Kleen
2009-12-14 13:08 ` Andi Kleen
2009-12-14 14:23 ` Larry Woodman
2009-12-14 14:23 ` Larry Woodman
2009-12-14 16:19 ` Andi Kleen
2009-12-14 16:19 ` Andi Kleen
2009-12-14 14:40 ` Rik van Riel
2009-12-14 14:40 ` Rik van Riel
2009-12-14 13:14 ` Christoph Hellwig
2009-12-14 13:14 ` Christoph Hellwig
2009-12-14 14:22 ` Larry Woodman
2009-12-14 14:22 ` Larry Woodman
2009-12-14 14:52 ` Rik van Riel
2009-12-14 14:52 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B22B89A.3060009@redhat.com \
--to=riel@redhat.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lwoodman@redhat.com \
--cc=minchan.kim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.