From: Li Zefan <lizf@cn.fujitsu.com>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: containers@lists.linux-foundation.org, linux-mm@kvack.org,
Paul Menage <menage@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
Pavel Emelyanov <xemul@openvz.org>,
Dan Malek <dan@embeddedalley.com>,
Vladislav Buzov <vbuzov@embeddedalley.com>,
Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC v2 1/4] cgroup: implement eventfd-based generic API for notifications
Date: Wed, 16 Dec 2009 10:00:32 +0800 [thread overview]
Message-ID: <4B283F40.5080706@cn.fujitsu.com> (raw)
In-Reply-To: <4B283B7F.2050403@cn.fujitsu.com>
>> +/*
>> + * Check if a file is a control file
>> + */
>> +static inline struct cftype *__file_cft(struct file *file)
>> +{
>> + if (file->f_dentry->d_inode->i_fop != &cgroup_file_operations)
>> + return ERR_PTR(-EINVAL);
>
> I don't think this check is needed.
>
Sorry, please ignore this comment
WARNING: multiple messages have this Message-ID (diff)
From: Li Zefan <lizf@cn.fujitsu.com>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: containers@lists.linux-foundation.org, linux-mm@kvack.org,
Paul Menage <menage@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
Pavel Emelyanov <xemul@openvz.org>,
Dan Malek <dan@embeddedalley.com>,
Vladislav Buzov <vbuzov@embeddedalley.com>,
Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC v2 1/4] cgroup: implement eventfd-based generic API for notifications
Date: Wed, 16 Dec 2009 10:00:32 +0800 [thread overview]
Message-ID: <4B283F40.5080706@cn.fujitsu.com> (raw)
In-Reply-To: <4B283B7F.2050403@cn.fujitsu.com>
>> +/*
>> + * Check if a file is a control file
>> + */
>> +static inline struct cftype *__file_cft(struct file *file)
>> +{
>> + if (file->f_dentry->d_inode->i_fop != &cgroup_file_operations)
>> + return ERR_PTR(-EINVAL);
>
> I don't think this check is needed.
>
Sorry, please ignore this comment
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-12-16 2:00 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-11 22:59 [PATCH RFC v2 0/4] cgroup notifications API and memory thresholds Kirill A. Shutemov
2009-12-11 22:59 ` Kirill A. Shutemov
2009-12-11 22:59 ` [PATCH RFC v2 1/4] cgroup: implement eventfd-based generic API for notifications Kirill A. Shutemov
2009-12-11 22:59 ` Kirill A. Shutemov
2009-12-15 9:11 ` Kirill A. Shutemov
2009-12-15 9:11 ` Kirill A. Shutemov
[not found] ` <cc557aab0912150111k41517b41t8999568db3bd8daa-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-12-15 9:35 ` KAMEZAWA Hiroyuki
2009-12-15 9:35 ` KAMEZAWA Hiroyuki
2009-12-15 9:35 ` KAMEZAWA Hiroyuki
[not found] ` <20091215183533.1a1e87d9.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2009-12-15 10:30 ` Kirill A. Shutemov
2009-12-15 15:03 ` Kirill A. Shutemov
2009-12-15 10:30 ` Kirill A. Shutemov
2009-12-15 10:30 ` Kirill A. Shutemov
2009-12-15 15:03 ` Kirill A. Shutemov
2009-12-15 15:03 ` Kirill A. Shutemov
[not found] ` <cc557aab0912150703qcfe6458paa7da71cb032cb93-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-12-15 23:55 ` KAMEZAWA Hiroyuki
2009-12-15 23:55 ` KAMEZAWA Hiroyuki
2009-12-15 23:55 ` KAMEZAWA Hiroyuki
2009-12-16 1:44 ` Li Zefan
2009-12-16 1:44 ` Li Zefan
2009-12-16 2:00 ` Li Zefan [this message]
2009-12-16 2:00 ` Li Zefan
[not found] ` <4B283B7F.2050403-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2009-12-16 2:00 ` Li Zefan
2009-12-16 5:46 ` Kirill A. Shutemov
2009-12-16 5:46 ` Kirill A. Shutemov
2009-12-16 5:46 ` Kirill A. Shutemov
[not found] ` <ca59c422b495907678915db636f70a8d029cbf3a.1260571675.git.kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org>
2009-12-15 9:11 ` Kirill A. Shutemov
2009-12-16 1:44 ` Li Zefan
[not found] ` <cover.1260571675.git.kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org>
2009-12-11 22:59 ` Kirill A. Shutemov
2009-12-11 22:59 ` [PATCH RFC v2 2/4] memcg: extract mem_group_usage() from mem_cgroup_read() Kirill A. Shutemov
2009-12-11 22:59 ` [PATCH RFC v2 3/4] memcg: rework usage of stats by soft limit Kirill A. Shutemov
2009-12-11 22:59 ` [PATCH RFC v2 4/4] memcg: implement memory thresholds Kirill A. Shutemov
2009-12-11 22:59 ` [PATCH RFC v2 2/4] memcg: extract mem_group_usage() from mem_cgroup_read() Kirill A. Shutemov
2009-12-11 22:59 ` Kirill A. Shutemov
[not found] ` <c1847dfb5c4fed1374b7add236d38e0db02eeef3.1260571675.git.kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org>
2009-12-16 8:40 ` Balbir Singh
2009-12-16 8:40 ` Balbir Singh
2009-12-16 8:40 ` Balbir Singh
2009-12-11 22:59 ` [PATCH RFC v2 3/4] memcg: rework usage of stats by soft limit Kirill A. Shutemov
2009-12-11 22:59 ` Kirill A. Shutemov
[not found] ` <747ea0ec22b9348208c80f86f7a813728bf8e50a.1260571675.git.kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org>
2009-12-12 3:50 ` Daisuke Nishimura
2009-12-12 3:50 ` Daisuke Nishimura
2009-12-12 3:50 ` Daisuke Nishimura
2009-12-12 13:06 ` Kirill A. Shutemov
2009-12-12 13:06 ` Kirill A. Shutemov
[not found] ` <cc557aab0912120506x56b9a707ob556035fdcf40a22-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-12-12 14:34 ` Daisuke Nishimura
2009-12-12 14:34 ` Daisuke Nishimura
2009-12-12 14:34 ` Daisuke Nishimura
2009-12-12 19:46 ` Kirill A. Shutemov
2009-12-12 19:46 ` Kirill A. Shutemov
2009-12-13 1:30 ` Daisuke Nishimura
2009-12-13 1:30 ` Daisuke Nishimura
[not found] ` <cc557aab0912121146y276a8d26v8baee15be1f83a97-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-12-13 1:30 ` Daisuke Nishimura
2009-12-15 1:35 ` KAMEZAWA Hiroyuki
2009-12-15 1:35 ` KAMEZAWA Hiroyuki
2009-12-15 1:35 ` KAMEZAWA Hiroyuki
[not found] ` <20091215103517.75645536.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2009-12-15 7:48 ` Kirill A. Shutemov
2009-12-15 7:48 ` Kirill A. Shutemov
2009-12-15 7:48 ` Kirill A. Shutemov
2009-12-15 8:07 ` KAMEZAWA Hiroyuki
2009-12-15 8:07 ` KAMEZAWA Hiroyuki
[not found] ` <cc557aab0912142348j6d0f6206qd751f74e416c6710-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-12-15 8:07 ` KAMEZAWA Hiroyuki
[not found] ` <20091212233409.60da66fb.d-nishimura-1T/T2zRcyZr+G+EEi5ephHgSJqDPrsil@public.gmane.org>
2009-12-12 19:46 ` Kirill A. Shutemov
[not found] ` <20091212125046.14df3134.d-nishimura-1T/T2zRcyZr+G+EEi5ephHgSJqDPrsil@public.gmane.org>
2009-12-12 13:06 ` Kirill A. Shutemov
2009-12-11 22:59 ` [PATCH RFC v2 4/4] memcg: implement memory thresholds Kirill A. Shutemov
2009-12-11 22:59 ` Kirill A. Shutemov
2009-12-12 3:19 ` Daisuke Nishimura
2009-12-12 3:19 ` Daisuke Nishimura
2009-12-12 13:11 ` Kirill A. Shutemov
2009-12-12 13:11 ` Kirill A. Shutemov
2009-12-12 13:13 ` Kirill A. Shutemov
2009-12-12 13:13 ` Kirill A. Shutemov
[not found] ` <cc557aab0912120511r7c83e97di3f97d2bb5eae326c-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-12-12 13:13 ` Kirill A. Shutemov
[not found] ` <20091212121902.e95f9561.d-nishimura-1T/T2zRcyZr+G+EEi5ephHgSJqDPrsil@public.gmane.org>
2009-12-12 13:11 ` Kirill A. Shutemov
[not found] ` <9e6e8d687224c6cbc54281f7c3d07983f701f93d.1260571675.git.kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org>
2009-12-12 3:19 ` Daisuke Nishimura
2009-12-15 1:58 ` KAMEZAWA Hiroyuki
2009-12-15 1:58 ` KAMEZAWA Hiroyuki
2009-12-15 1:58 ` KAMEZAWA Hiroyuki
2009-12-15 10:46 ` Kirill A. Shutemov
2009-12-15 10:46 ` Kirill A. Shutemov
2009-12-15 11:09 ` KAMEZAWA Hiroyuki
2009-12-15 11:09 ` KAMEZAWA Hiroyuki
[not found] ` <cc557aab0912150246k476aa85m6c1b61045fb0b26e-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-12-15 11:09 ` KAMEZAWA Hiroyuki
[not found] ` <20091215105850.87203454.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2009-12-15 10:46 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B283F40.5080706@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=containers@lists.linux-foundation.org \
--cc=dan@embeddedalley.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=menage@google.com \
--cc=nishimura@mxp.nes.nec.co.jp \
--cc=vbuzov@embeddedalley.com \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.