[LTP] [PATCH 1/3] ade: fix the bug of objdump01

[LTP] [PATCH 1/3] ade: fix the bug of objdump01

[liubo]

- LTP needs to test "objdump", but ade's Makefile exclude it.
- objdump01 case uses *.obj instead, so s/*.o/*.obj/

This patch fixed these.

Signed-off-by: Liu Bo <liubo2009@cn.fujitsu.com>

---
 testcases/commands/ade/Makefile          |    2 +-
 testcases/commands/ade/objdump/Makefile  |    4 ++--
 testcases/commands/ade/objdump/objdump01 |    2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/testcases/commands/ade/Makefile b/testcases/commands/ade/Makefile
index cf7a487..79de5ec 100644
--- a/testcases/commands/ade/Makefile
+++ b/testcases/commands/ade/Makefile
@@ -25,6 +25,6 @@ top_srcdir		?= ../../..
 include $(top_srcdir)/include/mk/env_pre.mk
 
 # XXX (garrcoop): objdump's Makefile needs fixing.
-FILTER_OUT_DIRS		:= objdump
+FILTER_OUT_DIRS		:= 
 
 include $(top_srcdir)/include/mk/generic_trunk_target.mk
diff --git a/testcases/commands/ade/objdump/Makefile b/testcases/commands/ade/objdump/Makefile
index 862438c..7fffc88 100644
--- a/testcases/commands/ade/objdump/Makefile
+++ b/testcases/commands/ade/objdump/Makefile
@@ -29,8 +29,8 @@ test: CPPFLAGS += -O
 test_arch.obj: test.o
 	mv $< "$@"
 
-test_D: test.o
-	$(LINK.o) $^ $(LOADLIBES) $(LDLIBS) $(OUTPUT_OPTION) $@
+test_D: test_arch.obj
+	$(LINK.o) $^ $(LOADLIBES) $(LDLIBS) $(OUTPUT_OPTION)
 
 INSTALL_TARGETS		:= objdump01
  
diff --git a/testcases/commands/ade/objdump/objdump01 b/testcases/commands/ade/objdump/objdump01
index 379a4f8..dd18e46 100755
--- a/testcases/commands/ade/objdump/objdump01
+++ b/testcases/commands/ade/objdump/objdump01
@@ -41,7 +41,7 @@ export DUMP=/usr/bin/objdump
 do_setup()
 {
 mkdir $TCtmp
-/usr/bin/ar -cr $TCtmp/lib.a $TCsrc/test_arch.o
+/usr/bin/ar -cr $TCtmp/lib.a $TCsrc/test_arch.obj
 
 echo 1; $DUMP -f $TCsrc/test > $TCtmp/er_dump_f
 echo 2; $DUMP -h $TCsrc/test > $TCtmp/er_dump_h
-- 
1.6.2.2






------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev 
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 1/3] ade: fix the bug of objdump01

[Garrett Cooper]

On Wed, Dec 16, 2009 at 3:37 AM, liubo <liubo2009@cn.fujitsu.com> wrote:
> - LTP needs to test "objdump", but ade's Makefile exclude it.
> - objdump01 case uses *.obj instead, so s/*.o/*.obj/
>
> This patch fixed these.
>
> Signed-off-by: Liu Bo <liubo2009@cn.fujitsu.com>
>
> ---
>  testcases/commands/ade/Makefile          |    2 +-
>  testcases/commands/ade/objdump/Makefile  |    4 ++--
>  testcases/commands/ade/objdump/objdump01 |    2 +-
>  3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/testcases/commands/ade/Makefile b/testcases/commands/ade/Makefile
> index cf7a487..79de5ec 100644
> --- a/testcases/commands/ade/Makefile
> +++ b/testcases/commands/ade/Makefile
> @@ -25,6 +25,6 @@ top_srcdir            ?= ../../..
>  include $(top_srcdir)/include/mk/env_pre.mk
>
>  # XXX (garrcoop): objdump's Makefile needs fixing.
> -FILTER_OUT_DIRS                := objdump
> +FILTER_OUT_DIRS                :=
>
>  include $(top_srcdir)/include/mk/generic_trunk_target.mk
> diff --git a/testcases/commands/ade/objdump/Makefile b/testcases/commands/ade/objdump/Makefile
> index 862438c..7fffc88 100644
> --- a/testcases/commands/ade/objdump/Makefile
> +++ b/testcases/commands/ade/objdump/Makefile
> @@ -29,8 +29,8 @@ test: CPPFLAGS += -O
>  test_arch.obj: test.o
>        mv $< "$@"
>
> -test_D: test.o
> -       $(LINK.o) $^ $(LOADLIBES) $(LDLIBS) $(OUTPUT_OPTION) $@
> +test_D: test_arch.obj
> +       $(LINK.o) $^ $(LOADLIBES) $(LDLIBS) $(OUTPUT_OPTION)
>
>  INSTALL_TARGETS                := objdump01
>
> diff --git a/testcases/commands/ade/objdump/objdump01 b/testcases/commands/ade/objdump/objdump01
> index 379a4f8..dd18e46 100755
> --- a/testcases/commands/ade/objdump/objdump01
> +++ b/testcases/commands/ade/objdump/objdump01
> @@ -41,7 +41,7 @@ export DUMP=/usr/bin/objdump
>  do_setup()
>  {
>  mkdir $TCtmp
> -/usr/bin/ar -cr $TCtmp/lib.a $TCsrc/test_arch.o
> +/usr/bin/ar -cr $TCtmp/lib.a $TCsrc/test_arch.obj
>
>  echo 1; $DUMP -f $TCsrc/test > $TCtmp/er_dump_f
>  echo 2; $DUMP -h $TCsrc/test > $TCtmp/er_dump_h

This was fixed last week, IIRC.
Thanks,
-Garrett

------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev 
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list