From: Milan Broz <mbroz@redhat.com>
To: Greg KH <greg@kroah.com>
Cc: device-mapper development <dm-devel@redhat.com>,
linux-kernel@vger.kernel.org, Alasdair G Kergon <agk@redhat.com>,
Zdenek Kabelac <zkabelac@redhat.com>
Subject: Re: Re: dm: sysfs add empty release function to avoid debug warning
Date: Wed, 16 Dec 2009 19:40:27 +0100 [thread overview]
Message-ID: <4B29299B.5080704@redhat.com> (raw)
In-Reply-To: <20091216174632.GA12473@kroah.com>
On 12/16/2009 06:46 PM, Greg KH wrote:
> You will find that all of these are modules, right? That's being worked
> on still.
probably. I see that this implementation is in kernel since import to git...
What's the right solution in this particular case?
It is exactly the same situation (using embedded kobj like module handle does).
In DM, the whole problem here is that kobject is used for attribute representation
of mapped device, mapped device struct is using its own reference counting
and can dissappear before the kobject. So it must properly solve this situation.
> Again, please fix your code not to have an empty release function. Will
> you revert this change and fix it properly?
Sure, working on it. Proper fix will replace this when ready.
Milan
WARNING: multiple messages have this Message-ID (diff)
From: Milan Broz <mbroz@redhat.com>
To: Greg KH <greg@kroah.com>
Cc: Zdenek Kabelac <zkabelac@redhat.com>,
device-mapper development <dm-devel@redhat.com>,
linux-kernel@vger.kernel.org, Alasdair G Kergon <agk@redhat.com>
Subject: Re: [dm-devel] Re: dm: sysfs add empty release function to avoid debug warning
Date: Wed, 16 Dec 2009 19:40:27 +0100 [thread overview]
Message-ID: <4B29299B.5080704@redhat.com> (raw)
In-Reply-To: <20091216174632.GA12473@kroah.com>
On 12/16/2009 06:46 PM, Greg KH wrote:
> You will find that all of these are modules, right? That's being worked
> on still.
probably. I see that this implementation is in kernel since import to git...
What's the right solution in this particular case?
It is exactly the same situation (using embedded kobj like module handle does).
In DM, the whole problem here is that kobject is used for attribute representation
of mapped device, mapped device struct is using its own reference counting
and can dissappear before the kobject. So it must properly solve this situation.
> Again, please fix your code not to have an empty release function. Will
> you revert this change and fix it properly?
Sure, working on it. Proper fix will replace this when ready.
Milan
next prev parent reply other threads:[~2009-12-16 18:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200912151735.nBFHZ8XP018683@hera.kernel.org>
2009-12-16 0:47 ` dm: sysfs add empty release function to avoid debug warning Greg KH
2009-12-16 9:44 ` Milan Broz
2009-12-16 13:45 ` Greg KH
2009-12-16 16:32 ` Zdenek Kabelac
2009-12-16 16:32 ` [dm-devel] " Zdenek Kabelac
2009-12-16 17:46 ` Greg KH
2009-12-16 17:46 ` [dm-devel] " Greg KH
2009-12-16 18:40 ` Milan Broz [this message]
2009-12-16 18:40 ` Milan Broz
2009-12-17 0:30 ` Greg KH
2009-12-17 0:30 ` [dm-devel] " Greg KH
2009-12-17 15:43 ` Milan Broz
2009-12-22 5:31 ` Greg KH
2009-12-16 23:25 ` Zdenek Kabelac
2009-12-16 23:25 ` [dm-devel] " Zdenek Kabelac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B29299B.5080704@redhat.com \
--to=mbroz@redhat.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=zkabelac@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.