* Re: kvm-ia64 spinlocks
@ 2009-12-17 8:21 Avi Kivity
0 siblings, 0 replies; only message in thread
From: Avi Kivity @ 2009-12-17 8:21 UTC (permalink / raw)
To: linux-ia64
On 12/17/2009 02:07 AM, Luck, Tony wrote:
> [resend with fixed vger address :-) ]
>
> Len Brown pointed out that allmodconfig is broken for
> ia64 because of:
>
> arch/ia64/kvm/vmm.c: In function 'vmm_spin_unlock':
> arch/ia64/kvm/vmm.c:70: error: 'spinlock_t' has no member named 'raw_lock'
>
> This is fall-out from the ia64 switch to ticket locks.
>
> I'm not sure why KVM needs to implement its own locking
> mechanisms ... if it does need to roll its own, it should
> not depend on the base kernel spinlock_t type.
It does, parts of the ia64 vmm run in guest context.
> One possible
> solution is to just have KVM define its own vmm_spinlock_t
> type (see patch below).
>
>
Looks good. Changelog/signoff?
> Or perhaps this code needs to implement ticket locks?
>
This will do for now, I believe.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2009-12-17 8:21 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-17 8:21 kvm-ia64 spinlocks Avi Kivity
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.