* [PATCH] Also clean up MISSING devices in --removemissing --force
@ 2009-12-17 11:03 Petr Rockai
2009-12-17 13:49 ` Milan Broz
0 siblings, 1 reply; 2+ messages in thread
From: Petr Rockai @ 2009-12-17 11:03 UTC (permalink / raw)
To: lvm-devel
Hi,
this is a simple patch that makes --removemissing --force treat
MISSING_PV devices the same way as --removemissing (without --force)
does. This should fix the last bit of RHBZ 537954.
Yours,
Petr.
===================================================================
RCS file: /cvs/lvm2/LVM2/tools/vgreduce.c,v
retrieving revision 1.98
diff -u -p -r1.98 vgreduce.c
--- tools/vgreduce.c 14 Sep 2009 22:47:50 -0000 1.98
+++ tools/vgreduce.c 17 Dec 2009 10:57:07 -0000
@@ -224,7 +224,7 @@ static int _make_vg_consistent(struct cm
*/
dm_list_iterate_safe(pvh, pvht, &vg->pvs) {
pvl = dm_list_item(pvh, struct pv_list);
- if (pvl->pv->dev)
+ if (pvl->pv->dev && !(pvl->pv->status & MISSING_PV))
continue;
if (!_remove_pv(vg, pvl, 0))
return_0;
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] Also clean up MISSING devices in --removemissing --force
2009-12-17 11:03 [PATCH] Also clean up MISSING devices in --removemissing --force Petr Rockai
@ 2009-12-17 13:49 ` Milan Broz
0 siblings, 0 replies; 2+ messages in thread
From: Milan Broz @ 2009-12-17 13:49 UTC (permalink / raw)
To: lvm-devel
On 12/17/2009 12:03 PM, Petr Rockai wrote:
> this is a simple patch that makes --removemissing --force treat
> MISSING_PV devices the same way as --removemissing (without --force)
> does. This should fix the last bit of RHBZ 537954.
> - if (pvl->pv->dev)
> + if (pvl->pv->dev && !(pvl->pv->status & MISSING_PV))
> continue;
> if (!_remove_pv(vg, pvl, 0))
> return_0;
ack.
Milan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-12-17 13:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-17 11:03 [PATCH] Also clean up MISSING devices in --removemissing --force Petr Rockai
2009-12-17 13:49 ` Milan Broz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.