Re: [PATCH] Paging and memory sharing for HVM guests

[Patrick Colp <pjcolp@cs.ubc.ca>]

[-- Attachment #1: Type: text/plain, Size: 1376 bytes --]

I've attached two patches which fix up the copyright and remove the 
commented out code. They can be applied in any order.


Patrick


Patrick Colp wrote:
>> 1). mem_event_xen_core.patch
>>
>> "Copyright (c) 2009 Citrix (R)&D) Ltd. (Patrick Colp)"
>>
>> The lawyers might not like it the copyright being assigned to a 
>> non-existent
>> entity :-(
> 
> Oops. That should be easy enough to fix.
> 
> 
>> 2).  mem_paging_xen_pfec_page_paged.patch:
>>
>> 15 +    if ( p2m_is_paging(p2mt) )
>>  16 +    {
>>  17 +//        if ( p2m_is_paged(p2mt) )
>>
>> I think you can safely remove the commented out code.
> 
> Yes we can. I thought I had removed all of the lines like that.
> 
> 
>> 3). mem_sharing_xen_mm.patch:
>>
>>  27 +    /*
>>  28 +     * Initialise our DOMID_IO domain.
>>                                 ^^->COW
>>  29 +     * This domain owns sharable pages.
>>  30 +     */
>>  31 +    dom_cow = domain_create(DOMID_COW, DOMCRF_dummy, 0);
>>
>>
>> 4), mem_sharing_tools_eagain.patch
>>
>> The code spins with a 1 second timeout forever. Would it make sense
>> to include a retry counter so that, say after an hour (or maybe something
>> much smaller) you give up?
> 
> I'll defer these to Grzegorz.
> 
> 
> Patrick
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel

[-- Attachment #2: mem_event_copyright_fix.patch --]
[-- Type: text/x-patch, Size: 592 bytes --]

Fix error in the copyright for mem_event.c.

Signed-off-by: Patrick Colp <Patrick.Colp@citrix.com>

diff -r 750a177eeca5 xen/arch/x86/mm/mem_event.c
--- a/xen/arch/x86/mm/mem_event.c	Thu Dec 17 16:09:19 2009 +0000
+++ b/xen/arch/x86/mm/mem_event.c	Thu Dec 17 09:17:11 2009 -0800
@@ -3,7 +3,7 @@
  *
  * Memory event support.
  *
- * Copyright (c) 2009 Citrix (R)&D) Ltd. (Patrick Colp)
+ * Copyright (c) 2009 Citrix (R&D) Ltd. (Patrick Colp)
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by

[-- Attachment #3: mem_paging_pfec_fix.patch --]
[-- Type: text/x-patch, Size: 1054 bytes --]

Remove commented out p2m paging type check code from guest_walk.c.

Signed-off-by: Patrick Colp <Patrick.Colp@citrix.com>

diff -r 568cd42c9156 xen/arch/x86/mm/hap/guest_walk.c
--- a/xen/arch/x86/mm/hap/guest_walk.c	Thu Dec 17 09:17:12 2009 -0800
+++ b/xen/arch/x86/mm/hap/guest_walk.c	Thu Dec 17 09:21:56 2009 -0800
@@ -49,8 +49,7 @@
     top_mfn = gfn_to_mfn_unshare(v->domain, cr3 >> PAGE_SHIFT, &p2mt, 0);
     if ( p2m_is_paging(p2mt) )
     {
-//        if ( p2m_is_paged(p2mt) )
-            p2m_mem_paging_populate(v->domain, cr3 >> PAGE_SHIFT);
+        p2m_mem_paging_populate(v->domain, cr3 >> PAGE_SHIFT);
 
         pfec[0] = PFEC_page_paged;
         return INVALID_GFN;
@@ -82,8 +81,7 @@
         gfn_to_mfn_unshare(v->domain, gfn_x(gfn), &p2mt, 0);
         if ( p2m_is_paging(p2mt) )
         {
-//            if ( p2m_is_paged(p2mt) )
-                p2m_mem_paging_populate(v->domain, gfn_x(gfn));
+            p2m_mem_paging_populate(v->domain, gfn_x(gfn));
 
             pfec[0] = PFEC_page_paged;
             return INVALID_GFN;

[-- Attachment #4: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel