Re: [PATCH] Paging and memory sharing for HVM guests

[Patrick Colp <pjcolp@cs.ubc.ca>]

[-- Attachment #1: Type: text/plain, Size: 970 bytes --]

OK. I've attached a patch to fix the include problem. I'll leave the 
xen/mem_event.h problem for now unless other people have it too.


Patrick


Jeremy Fitzhardinge wrote:
> On 12/17/2009 12:15 PM, Jeremy Fitzhardinge wrote:
>> On 12/17/2009 12:08 PM, Patrick Colp wrote:
>>> That's odd. I just pulled a fresh copy of xen-unstable and built xen 
>>> and the tools. Both compiled with no errors or problems. Maybe this 
>>> is some sort of distro-dependent problem?
>>
>> Possibly.  I'm using Fedora 11 on this machine, and it also fails in 
>> Fedora 12.  For the sleep() prototype, is it possible your versions 
>> headers are implicitly including unistd.h, or otherwise have a 
>> prototype for it?
>>
>> And for the xen/mem_event.h problem, might you have that header 
>> installed somewhere?
> 
> Though I just did a clean+build and it found the header, so maybe it was 
> something in the header symlink mess.
> 
> So just the sleep prototype problem.
> 
>     J

[-- Attachment #2: mem_sharing_bidir_daemon_include_fix.patch --]
[-- Type: text/x-patch, Size: 458 bytes --]

Add missing unistd.h header file which causes the build to fail on some
systems.

Signed-off-by: Patrick Colp <Patrick.Colp@citrix.com>

diff -r b47dfc7f5918 tools/memshr/bidir-daemon.c
--- a/tools/memshr/bidir-daemon.c	Thu Dec 17 09:21:56 2009 -0800
+++ b/tools/memshr/bidir-daemon.c	Thu Dec 17 12:19:57 2009 -0800
@@ -18,6 +18,7 @@
  */
 #include <pthread.h>
 #include <inttypes.h>
+#include <unistd.h>
 
 #include "bidir-hash.h"
 #include "memshr-priv.h"

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel