From: Tiger Yang <tiger.yang@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 1/1] ocfs2-devel: remove redundant OCFS2_MOUNT_POSIX_ACL check in ocfs2_get_acl_nolock()
Date: Fri, 18 Dec 2009 10:11:58 +0800 [thread overview]
Message-ID: <4B2AE4EE.7050208@oracle.com> (raw)
In-Reply-To: <1260857308-25404-1-git-send-email-jeff.liu@oracle.com>
Acked-by: Tiger Yang <tiger.yang@oracle.com>
On 12/15/2009 02:08 PM, Jeff Liu wrote:
> osb->s_mount_opt has already been checked against OCFS2_MOUNT_POSIX_ACL_CHECK before
> calling ocfs2_get_acl_nolock() in ocfs2_init_acl()&& ocfs2_get_acl(), so remove it.
>
> Signed-off-by: Jeff Liu<jeff.liu@oracle.com>
> ---
> fs/ocfs2/acl.c | 3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/fs/ocfs2/acl.c b/fs/ocfs2/acl.c
> index fbeaec7..42d70b7 100644
> --- a/fs/ocfs2/acl.c
> +++ b/fs/ocfs2/acl.c
> @@ -104,9 +104,6 @@ static struct posix_acl *ocfs2_get_acl_nolock(struct inode *inode,
> struct posix_acl *acl;
> int retval;
>
> - if (!(osb->s_mount_opt& OCFS2_MOUNT_POSIX_ACL))
> - return NULL;
> -
> switch (type) {
> case ACL_TYPE_ACCESS:
> name_index = OCFS2_XATTR_INDEX_POSIX_ACL_ACCESS;
prev parent reply other threads:[~2009-12-18 2:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-15 6:08 [Ocfs2-devel] [PATCH 1/1] ocfs2-devel: remove redundant OCFS2_MOUNT_POSIX_ACL check in ocfs2_get_acl_nolock() Jeff Liu
2009-12-18 2:11 ` Tiger Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B2AE4EE.7050208@oracle.com \
--to=tiger.yang@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.