All of lore.kernel.org
 help / color / mirror / Atom feed
* [Ocfs2-devel] [PATCH 1/1] ocfs2-devel: remove redundant OCFS2_MOUNT_POSIX_ACL check in ocfs2_get_acl_nolock()
@ 2009-12-15  6:08 Jeff Liu
  2009-12-18  2:11 ` Tiger Yang
  0 siblings, 1 reply; 2+ messages in thread
From: Jeff Liu @ 2009-12-15  6:08 UTC (permalink / raw)
  To: ocfs2-devel

osb->s_mount_opt has already been checked against OCFS2_MOUNT_POSIX_ACL_CHECK before
calling ocfs2_get_acl_nolock() in ocfs2_init_acl() && ocfs2_get_acl(), so remove it.

Signed-off-by: Jeff Liu <jeff.liu@oracle.com>
---
 fs/ocfs2/acl.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/fs/ocfs2/acl.c b/fs/ocfs2/acl.c
index fbeaec7..42d70b7 100644
--- a/fs/ocfs2/acl.c
+++ b/fs/ocfs2/acl.c
@@ -104,9 +104,6 @@ static struct posix_acl *ocfs2_get_acl_nolock(struct inode *inode,
 	struct posix_acl *acl;
 	int retval;
 
-	if (!(osb->s_mount_opt & OCFS2_MOUNT_POSIX_ACL))
-		return NULL;
-
 	switch (type) {
 	case ACL_TYPE_ACCESS:
 		name_index = OCFS2_XATTR_INDEX_POSIX_ACL_ACCESS;
-- 
1.5.4.3

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Ocfs2-devel] [PATCH 1/1] ocfs2-devel: remove redundant OCFS2_MOUNT_POSIX_ACL check in ocfs2_get_acl_nolock()
  2009-12-15  6:08 [Ocfs2-devel] [PATCH 1/1] ocfs2-devel: remove redundant OCFS2_MOUNT_POSIX_ACL check in ocfs2_get_acl_nolock() Jeff Liu
@ 2009-12-18  2:11 ` Tiger Yang
  0 siblings, 0 replies; 2+ messages in thread
From: Tiger Yang @ 2009-12-18  2:11 UTC (permalink / raw)
  To: ocfs2-devel

Acked-by: Tiger Yang <tiger.yang@oracle.com>

On 12/15/2009 02:08 PM, Jeff Liu wrote:
> osb->s_mount_opt has already been checked against OCFS2_MOUNT_POSIX_ACL_CHECK before
> calling ocfs2_get_acl_nolock() in ocfs2_init_acl()&&  ocfs2_get_acl(), so remove it.
>
> Signed-off-by: Jeff Liu<jeff.liu@oracle.com>
> ---
>   fs/ocfs2/acl.c |    3 ---
>   1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/fs/ocfs2/acl.c b/fs/ocfs2/acl.c
> index fbeaec7..42d70b7 100644
> --- a/fs/ocfs2/acl.c
> +++ b/fs/ocfs2/acl.c
> @@ -104,9 +104,6 @@ static struct posix_acl *ocfs2_get_acl_nolock(struct inode *inode,
>   	struct posix_acl *acl;
>   	int retval;
>
> -	if (!(osb->s_mount_opt&  OCFS2_MOUNT_POSIX_ACL))
> -		return NULL;
> -
>   	switch (type) {
>   	case ACL_TYPE_ACCESS:
>   		name_index = OCFS2_XATTR_INDEX_POSIX_ACL_ACCESS;

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-12-18  2:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-15  6:08 [Ocfs2-devel] [PATCH 1/1] ocfs2-devel: remove redundant OCFS2_MOUNT_POSIX_ACL check in ocfs2_get_acl_nolock() Jeff Liu
2009-12-18  2:11 ` Tiger Yang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.