* [PATCH] Rename mirror_device_fault_policy to mirror_image_fault policy
@ 2009-12-20 14:45 Petr Rockai
2009-12-20 16:01 ` Milan Broz
0 siblings, 1 reply; 2+ messages in thread
From: Petr Rockai @ 2009-12-20 14:45 UTC (permalink / raw)
To: lvm-devel
This should be quite simple, but I have thrown in a simple testcase as
well, for a good measure. There is some code duplication, but I'll
address that separately, since the old codepath (which does not really
do any upconversion, just logs suggestions) is still employed by
vgreduce --removemissing --force. This ought to be simplified to just
remove the faulty images/logs without looking at the policy or writing
any hints (vgreduce --removemissing should issue a hint about lvconvert
--repair instead).
This should fix RHBZ 538620.
Yours,
Petr.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mirror_image_fault_policy.diff
Type: text/x-diff
Size: 4171 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/lvm-devel/attachments/20091220/51717728/attachment.bin>
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] Rename mirror_device_fault_policy to mirror_image_fault policy
2009-12-20 14:45 [PATCH] Rename mirror_device_fault_policy to mirror_image_fault policy Petr Rockai
@ 2009-12-20 16:01 ` Milan Broz
0 siblings, 0 replies; 2+ messages in thread
From: Milan Broz @ 2009-12-20 16:01 UTC (permalink / raw)
To: lvm-devel
On 12/20/2009 03:45 PM, Petr Rockai wrote:
> This should be quite simple, but I have thrown in a simple testcase as
> well, for a good measure. There is some code duplication, but I'll
> address that separately, since the old codepath (which does not really
> do any upconversion, just logs suggestions) is still employed by
> vgreduce --removemissing --force. This ought to be simplified to just
> remove the faulty images/logs without looking at the policy or writing
> any hints (vgreduce --removemissing should issue a hint about lvconvert
> --repair instead).
ack for patch, grumble for posting it so late.
(for vgreduce simplification, take into account problems described in patch
I just posted...)
Milan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-12-20 16:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-20 14:45 [PATCH] Rename mirror_device_fault_policy to mirror_image_fault policy Petr Rockai
2009-12-20 16:01 ` Milan Broz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.