All of lore.kernel.org
 help / color / mirror / Atom feed
From: Liuwenyi <qingshenlwy@gmail.com>
To: tytso@mit.edu, adilger@sun.com, viro@zeniv.linux.org.uk,
	jmorris@namei.org, joel.becker@oracle.com, serue@us.ibm.com,
	hch@lst.de, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.
Subject: [PATCHv2 05/12]posix_acl: Add the check items
Date: Mon, 21 Dec 2009 19:57:19 +0800	[thread overview]
Message-ID: <4B2F629F.1000401@gmail.com> (raw)

move the ACL validation check in to fs/posix_acl.c.
Including nullpointer check and PTR_ERR check.

---
Signed-off-by: Liuwenyi <qingshenlwy@gmail.com>
Cc: "Theodore Ts'o" <tytso@mit.edu>
Cc: Andreas Dilger <adilger@sun.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: James Morris <jmorris@namei.org>
Cc: Joel Becker <joel.becker@oracle.com>
Cc: Serge Hallyn <serue@us.ibm.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: linux-ext4@vger.kernel.org
Cc: linux-kernel@vger.kernel.org

---
diff --git a/fs/ext4/acl.c b/fs/ext4/acl.c
index 8a2a29d..aeb41ca 100644
--- a/fs/ext4/acl.c
+++ b/fs/ext4/acl.c
@@ -430,13 +430,11 @@ ext4_xattr_set_acl(struct dentry *dentry, const
char *name, const void *value,

if (value) {
acl = posix_acl_from_xattr(value, size);
- if (IS_ERR(acl))
- return PTR_ERR(acl);
- else if (acl) {
- error = posix_acl_valid(acl);
- if (error)
- goto release_and_out;
- }
+
+ error = posix_acl_valid(acl);
+ if (error)
+ goto release_and_out;
+
} else
acl = NULL;


-- 
Best Regards,
Liuwenyi


WARNING: multiple messages have this Message-ID (diff)
From: Liuwenyi <qingshenlwy@gmail.com>
To: tytso@mit.edu, adilger@sun.com, viro@zeniv.linux.org.uk,
	jmorris@namei.org, joel.becker@oracle.com, serue@us.ibm.com,
	hch@lst.de, linux-ext4@vger.kernel.org,
	linux-kernel@vger.kernel.org, onlyflyer@gmail.com,
	strongzgy@gmail.com
Subject: [PATCHv2 05/12]posix_acl: Add the check items
Date: Mon, 21 Dec 2009 19:57:19 +0800	[thread overview]
Message-ID: <4B2F629F.1000401@gmail.com> (raw)

move the ACL validation check in to fs/posix_acl.c.
Including nullpointer check and PTR_ERR check.

---
Signed-off-by: Liuwenyi <qingshenlwy@gmail.com>
Cc: "Theodore Ts'o" <tytso@mit.edu>
Cc: Andreas Dilger <adilger@sun.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: James Morris <jmorris@namei.org>
Cc: Joel Becker <joel.becker@oracle.com>
Cc: Serge Hallyn <serue@us.ibm.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: linux-ext4@vger.kernel.org
Cc: linux-kernel@vger.kernel.org

---
diff --git a/fs/ext4/acl.c b/fs/ext4/acl.c
index 8a2a29d..aeb41ca 100644
--- a/fs/ext4/acl.c
+++ b/fs/ext4/acl.c
@@ -430,13 +430,11 @@ ext4_xattr_set_acl(struct dentry *dentry, const
char *name, const void *value,

if (value) {
acl = posix_acl_from_xattr(value, size);
- if (IS_ERR(acl))
- return PTR_ERR(acl);
- else if (acl) {
- error = posix_acl_valid(acl);
- if (error)
- goto release_and_out;
- }
+
+ error = posix_acl_valid(acl);
+ if (error)
+ goto release_and_out;
+
} else
acl = NULL;


-- 
Best Regards,
Liuwenyi


             reply	other threads:[~2009-12-21 11:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-21 11:57 Liuwenyi [this message]
2009-12-21 11:57 ` [PATCHv2 05/12]posix_acl: Add the check items Liuwenyi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B2F629F.1000401@gmail.com \
    --to=qingshenlwy@gmail.com \
    --cc=adilger@sun.com \
    --cc=hch@lst.de \
    --cc=jmorris@namei.org \
    --cc=joel.becker@oracle.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel. \
    --cc=serue@us.ibm.com \
    --cc=tytso@mit.edu \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.