All of lore.kernel.org
 help / color / mirror / Atom feed
From: Liuwenyi <qingshenlwy@gmail.com>
To: aelder@sgi.com, xfs-masters@oss.sgi.com, hch@lst.de,
	viro@zeniv.linux.org.uk, sandeen@sandeen.net,
	joel.becker@oracle.com, xfs@oss.sgi.com,
	linux-kernel@vger.kernel.org, strongzgy@gmail.com,
	onlyflyer@gmail.com
Subject: [PATCHv2 12/12]posix_acl: Add the check items
Date: Mon, 21 Dec 2009 20:03:19 +0800	[thread overview]
Message-ID: <4B2F6407.4060805@gmail.com> (raw)

move the ACL validation check in to fs/posix_acl.c.
Including nullpointer check and PTR_ERR check.

---
Signed-off-by: Liuwenyi <qingshenlwy@gmail.com>
Cc: Alex Elder <aelder@sgi.com>
Cc: xfs-masters@oss.sgi.com
Cc :Christoph Hellwig <hch@lst.de>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Eric Sandeen <sandeen@sandeen.net>
Cc: Joel Becker <joel.becker@oracle.com>
Cc: xfs@oss.sgi.com
Cc: linux-kernel@vger.kernel.org

---
diff --git a/fs/xfs/linux-2.6/xfs_acl.c b/fs/xfs/linux-2.6/xfs_acl.c
index 2512125..3de2533 100644
--- a/fs/xfs/linux-2.6/xfs_acl.c
+++ b/fs/xfs/linux-2.6/xfs_acl.c
@@ -392,17 +392,6 @@ xfs_xattr_acl_set(struct dentry *dentry, const char
*name,
goto set_acl;

acl = posix_acl_from_xattr(value, size);
- if (!acl) {
- /*
- * acl_set_file(3) may request that we set default ACLs with
- * zero length -- defend (gracefully) against that here.
- */
- goto out;
- }
- if (IS_ERR(acl)) {
- error = PTR_ERR(acl);
- goto out;
- }

error = posix_acl_valid(acl);
if (error)

-- 
Best Regards,
Liuwenyi

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

WARNING: multiple messages have this Message-ID (diff)
From: Liuwenyi <qingshenlwy@gmail.com>
To: aelder@sgi.com, xfs-masters@oss.sgi.com, hch@lst.de,
	viro@zeniv.linux.org.uk, sandeen@sandeen.net,
	joel.becker@oracle.com, xfs@oss.sgi.com,
	linux-kernel@vger.kernel.org, strongzgy@gmail.com,
	onlyflyer@gmail.com
Subject: [PATCHv2 12/12]posix_acl: Add the check items
Date: Mon, 21 Dec 2009 20:03:19 +0800	[thread overview]
Message-ID: <4B2F6407.4060805@gmail.com> (raw)

move the ACL validation check in to fs/posix_acl.c.
Including nullpointer check and PTR_ERR check.

---
Signed-off-by: Liuwenyi <qingshenlwy@gmail.com>
Cc: Alex Elder <aelder@sgi.com>
Cc: xfs-masters@oss.sgi.com
Cc :Christoph Hellwig <hch@lst.de>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Eric Sandeen <sandeen@sandeen.net>
Cc: Joel Becker <joel.becker@oracle.com>
Cc: xfs@oss.sgi.com
Cc: linux-kernel@vger.kernel.org

---
diff --git a/fs/xfs/linux-2.6/xfs_acl.c b/fs/xfs/linux-2.6/xfs_acl.c
index 2512125..3de2533 100644
--- a/fs/xfs/linux-2.6/xfs_acl.c
+++ b/fs/xfs/linux-2.6/xfs_acl.c
@@ -392,17 +392,6 @@ xfs_xattr_acl_set(struct dentry *dentry, const char
*name,
goto set_acl;

acl = posix_acl_from_xattr(value, size);
- if (!acl) {
- /*
- * acl_set_file(3) may request that we set default ACLs with
- * zero length -- defend (gracefully) against that here.
- */
- goto out;
- }
- if (IS_ERR(acl)) {
- error = PTR_ERR(acl);
- goto out;
- }

error = posix_acl_valid(acl);
if (error)

-- 
Best Regards,
Liuwenyi


             reply	other threads:[~2009-12-21 12:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-21 12:03 Liuwenyi [this message]
2009-12-21 12:03 ` [PATCHv2 12/12]posix_acl: Add the check items Liuwenyi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B2F6407.4060805@gmail.com \
    --to=qingshenlwy@gmail.com \
    --cc=aelder@sgi.com \
    --cc=hch@lst.de \
    --cc=joel.becker@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=onlyflyer@gmail.com \
    --cc=sandeen@sandeen.net \
    --cc=strongzgy@gmail.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=xfs-masters@oss.sgi.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.