* [PATCH 2/2] libdrm: Unreference pushbuf objects on channel destruction
@ 2009-12-21 14:11 Krzysztof Smiechowicz
0 siblings, 0 replies; 3+ messages in thread
From: Krzysztof Smiechowicz @ 2009-12-21 14:11 UTC (permalink / raw)
To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
- unreference pushbuf objects on channel destruction
Index: nouveau/nouveau_pushbuf.c
===================================================================
--- nouveau/nouveau_pushbuf.c (wersja 32082)
+++ nouveau/nouveau_pushbuf.c (kopia robocza)
@@ -262,6 +262,12 @@
return 0;
}
+void
+nouveau_pushbuf_fini(struct nouveau_channel *chan)
+{
+ nouveau_pushbuf_fini_call(chan);
+}
+
int
nouveau_pushbuf_flush(struct nouveau_channel *chan, unsigned min)
{
Index: nouveau/nouveau_private.h
===================================================================
--- nouveau/nouveau_private.h (wersja 32082)
+++ nouveau/nouveau_private.h (kopia robocza)
@@ -65,6 +65,9 @@
int
nouveau_pushbuf_init(struct nouveau_channel *);
+void
+nouveau_pushbuf_fini(struct nouveau_channel *);
+
struct nouveau_channel_priv {
struct nouveau_channel base;
Index: nouveau/nouveau_channel.c
===================================================================
--- nouveau/nouveau_channel.c (wersja 32002)
+++ nouveau/nouveau_channel.c (kopia robocza)
@@ -111,6 +111,8 @@
FIRE_RING(&nvchan->base);
+ nouveau_pushbuf_fini(&nvchan->base);
+
nouveau_bo_unmap(nvchan->notifier_bo);
nouveau_bo_ref(NULL, &nvchan->notifier_bo);
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 2/2] libdrm: Unreference pushbuf objects on channel destruction
@ 2009-12-27 10:02 Krzysztof Smiechowicz
[not found] ` <4B3730C4.6000903-5tc4TXWwyLM@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Smiechowicz @ 2009-12-27 10:02 UTC (permalink / raw)
To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
(resending as git patch)
- unreference pushbuf objects on channel destruction
diff --git a/nouveau/nouveau_channel.c b/nouveau/nouveau_channel.c
index 674c5c3..6f71f89 100644
--- a/nouveau/nouveau_channel.c
+++ b/nouveau/nouveau_channel.c
@@ -111,6 +111,8 @@ nouveau_channel_free(struct nouveau_channel **chan)
FIRE_RING(&nvchan->base);
+ nouveau_pushbuf_fini(&nvchan->base);
+
nouveau_bo_unmap(nvchan->notifier_bo);
nouveau_bo_ref(NULL, &nvchan->notifier_bo);
diff --git a/nouveau/nouveau_private.h b/nouveau/nouveau_private.h
index 784afc9..de21a6b 100644
--- a/nouveau/nouveau_private.h
+++ b/nouveau/nouveau_private.h
@@ -65,6 +65,9 @@ struct nouveau_pushbuf_priv {
int
nouveau_pushbuf_init(struct nouveau_channel *);
+void
+nouveau_pushbuf_fini(struct nouveau_channel *);
+
struct nouveau_channel_priv {
struct nouveau_channel base;
diff --git a/nouveau/nouveau_pushbuf.c b/nouveau/nouveau_pushbuf.c
index b90e923..c4053ed 100644
--- a/nouveau/nouveau_pushbuf.c
+++ b/nouveau/nouveau_pushbuf.c
@@ -170,6 +170,12 @@ nouveau_pushbuf_init(struct nouveau_channel *chan)
return 0;
}
+void
+nouveau_pushbuf_fini(struct nouveau_channel *chan)
+{
+ nouveau_pushbuf_fini_call(chan);
+}
+
int
nouveau_pushbuf_flush(struct nouveau_channel *chan, unsigned min)
{
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] libdrm: Unreference pushbuf objects on channel destruction
[not found] ` <4B3730C4.6000903-5tc4TXWwyLM@public.gmane.org>
@ 2009-12-28 23:08 ` Younes Manton
0 siblings, 0 replies; 3+ messages in thread
From: Younes Manton @ 2009-12-28 23:08 UTC (permalink / raw)
To: Krzysztof Smiechowicz; +Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
On Sun, Dec 27, 2009 at 5:02 AM, Krzysztof Smiechowicz <deadwood-5tc4TXWwyLM@public.gmane.org> wrote:
> (resending as git patch)
>
> - unreference pushbuf objects on channel destruction
>
>
> diff --git a/nouveau/nouveau_channel.c b/nouveau/nouveau_channel.c
> index 674c5c3..6f71f89 100644
> --- a/nouveau/nouveau_channel.c
> +++ b/nouveau/nouveau_channel.c
> @@ -111,6 +111,8 @@ nouveau_channel_free(struct nouveau_channel **chan)
>
> FIRE_RING(&nvchan->base);
>
> + nouveau_pushbuf_fini(&nvchan->base);
> +
> nouveau_bo_unmap(nvchan->notifier_bo);
> nouveau_bo_ref(NULL, &nvchan->notifier_bo);
>
> diff --git a/nouveau/nouveau_private.h b/nouveau/nouveau_private.h
> index 784afc9..de21a6b 100644
> --- a/nouveau/nouveau_private.h
> +++ b/nouveau/nouveau_private.h
> @@ -65,6 +65,9 @@ struct nouveau_pushbuf_priv {
> int
> nouveau_pushbuf_init(struct nouveau_channel *);
>
> +void
> +nouveau_pushbuf_fini(struct nouveau_channel *);
> +
> struct nouveau_channel_priv {
> struct nouveau_channel base;
>
> diff --git a/nouveau/nouveau_pushbuf.c b/nouveau/nouveau_pushbuf.c
> index b90e923..c4053ed 100644
> --- a/nouveau/nouveau_pushbuf.c
> +++ b/nouveau/nouveau_pushbuf.c
> @@ -170,6 +170,12 @@ nouveau_pushbuf_init(struct nouveau_channel *chan)
> return 0;
> }
>
> +void
> +nouveau_pushbuf_fini(struct nouveau_channel *chan)
> +{
> + nouveau_pushbuf_fini_call(chan);
> +}
> +
> int
> nouveau_pushbuf_flush(struct nouveau_channel *chan, unsigned min)
> {
Pushed both. I had to apply them by hand along with a few minor
additions since they would still not apply cleanly. They probably
needed a rebase. Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-12-28 23:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-21 14:11 [PATCH 2/2] libdrm: Unreference pushbuf objects on channel destruction Krzysztof Smiechowicz
-- strict thread matches above, loose matches on Subject: below --
2009-12-27 10:02 Krzysztof Smiechowicz
[not found] ` <4B3730C4.6000903-5tc4TXWwyLM@public.gmane.org>
2009-12-28 23:08 ` Younes Manton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.