2.6.33-rc1 build failure: copy_from_user() buffer size is not provably correct

2.6.33-rc1 build failure: copy_from_user() buffer size is not provably correct

[Ritesh Raj Sarraf]

This is triggered if using the 'allyesconfig' target.

A similar issue was this: 2886a8bdfa007053b414ab01741a98c18c376a85


debian-build:/tmp/all-yes-config/2.6.33-rc1# make deb-pkg
make KBUILD_SRC=                                         
  CHK     include/linux/version.h                        
  CHK     include/generated/utsrelease.h                 
  CALL    scripts/checksyscalls.sh                       
  CHK     include/generated/compile.h                    
  VDSOSYM arch/x86/vdso/vdso32-int80-syms.lds
  VDSOSYM arch/x86/vdso/vdso32-sysenter-syms.lds
  VDSOSYM arch/x86/vdso/vdso32-syms.lds
  LD      arch/x86/vdso/built-in.o
  LD      arch/x86/built-in.o
  CC      mm/migrate.o
In file included from /tmp/all-yes-config/2.6.33-
rc1/arch/x86/include/asm/uaccess.h:571,
                 from include/linux/uaccess.h:5,
                 from include/linux/highmem.h:6,
                 from include/linux/pagemap.h:10,
                 from include/linux/mempolicy.h:62,
                 from include/linux/migrate.h:5,
                 from mm/migrate.c:15:
In function ‘copy_from_user’,
    inlined from ‘do_pages_stat’ at mm/migrate.c:1009:
/tmp/all-yes-config/2.6.33-rc1/arch/x86/include/asm/uaccess_32.h:213: error: 
call to ‘copy_from_user_overflow’ declared with attribute error: 
copy_from_user() buffer size is not provably correct
make[3]: *** [mm/migrate.o] Error 1
make[2]: *** [mm] Error 2
make[1]: *** [deb-pkg] Error 2
make: *** [deb-pkg] Error 2


Regards,
Ritesh
-- 
Given the large number of mailing lists I follow, I request you to CC me
in replies for quicker response

Re: 2.6.33-rc1 build failure: copy_from_user() buffer size is not provably correct

[KOSAKI Motohiro]

> This is triggered if using the 'allyesconfig' target.
> 
> A similar issue was this: 2886a8bdfa007053b414ab01741a98c18c376a85
> 
> 
> debian-build:/tmp/all-yes-config/2.6.33-rc1# make deb-pkg
> make KBUILD_SRC=                                         
>   CHK     include/linux/version.h                        
>   CHK     include/generated/utsrelease.h                 
>   CALL    scripts/checksyscalls.sh                       
>   CHK     include/generated/compile.h                    
>   VDSOSYM arch/x86/vdso/vdso32-int80-syms.lds
>   VDSOSYM arch/x86/vdso/vdso32-sysenter-syms.lds
>   VDSOSYM arch/x86/vdso/vdso32-syms.lds
>   LD      arch/x86/vdso/built-in.o
>   LD      arch/x86/built-in.o
>   CC      mm/migrate.o
> In file included from /tmp/all-yes-config/2.6.33-
> rc1/arch/x86/include/asm/uaccess.h:571,
>                  from include/linux/uaccess.h:5,
>                  from include/linux/highmem.h:6,
>                  from include/linux/pagemap.h:10,
>                  from include/linux/mempolicy.h:62,
>                  from include/linux/migrate.h:5,
>                  from mm/migrate.c:15:
> In function ‘copy_from_user’,
>     inlined from ‘do_pages_stat’ at mm/migrate.c:1009:
> /tmp/all-yes-config/2.6.33-rc1/arch/x86/include/asm/uaccess_32.h:213: error: 
> call to ‘copy_from_user_overflow’ declared with attribute error: 
> copy_from_user() buffer size is not provably correct

afaik, ingo already queued this fix.
please wait (very) few days.

thanks.




> make[3]: *** [mm/migrate.o] Error 1
> make[2]: *** [mm] Error 2
> make[1]: *** [deb-pkg] Error 2
> make: *** [deb-pkg] Error 2
> 
> 
> Regards,
> Ritesh
> -- 
> Given the large number of mailing lists I follow, I request you to CC me
> in replies for quicker response
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

Re: 2.6.33-rc1 build failure: copy_from_user() buffer size is not provably correct

[Ingo Molnar]

* KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:

> > This is triggered if using the 'allyesconfig' target.
> > 
> > A similar issue was this: 2886a8bdfa007053b414ab01741a98c18c376a85
> > 
> > 
> > debian-build:/tmp/all-yes-config/2.6.33-rc1# make deb-pkg
> > make KBUILD_SRC=                                         
> >   CHK     include/linux/version.h                        
> >   CHK     include/generated/utsrelease.h                 
> >   CALL    scripts/checksyscalls.sh                       
> >   CHK     include/generated/compile.h                    
> >   VDSOSYM arch/x86/vdso/vdso32-int80-syms.lds
> >   VDSOSYM arch/x86/vdso/vdso32-sysenter-syms.lds
> >   VDSOSYM arch/x86/vdso/vdso32-syms.lds
> >   LD      arch/x86/vdso/built-in.o
> >   LD      arch/x86/built-in.o
> >   CC      mm/migrate.o
> > In file included from /tmp/all-yes-config/2.6.33-
> > rc1/arch/x86/include/asm/uaccess.h:571,
> >                  from include/linux/uaccess.h:5,
> >                  from include/linux/highmem.h:6,
> >                  from include/linux/pagemap.h:10,
> >                  from include/linux/mempolicy.h:62,
> >                  from include/linux/migrate.h:5,
> >                  from mm/migrate.c:15:
> > In function ???copy_from_user???,
> >     inlined from ???do_pages_stat??? at mm/migrate.c:1009:
> > /tmp/all-yes-config/2.6.33-rc1/arch/x86/include/asm/uaccess_32.h:213: error: 
> > call to ???copy_from_user_overflow??? declared with attribute error: 
> > copy_from_user() buffer size is not provably correct
> 
> afaik, ingo already queued this fix.
> please wait (very) few days.
> 
> thanks.

hm, the one mm/migrate.c fix we had is already in -rc1:

 b9255850: mm: Adjust do_pages_stat() so gcc can see copy_from_user() is safe

I've Cc:-ed more folks.

	Ingo

Re: 2.6.33-rc1 build failure: copy_from_user() buffer size is not provably correct

[Ritesh Raj Sarraf]

[-- Attachment #1: Type: Text/Plain, Size: 622 bytes --]

Hi Ingo,

On Monday 21 Dec 2009 14:43:30 Ingo Molnar wrote:
> hm, the one mm/migrate.c fix we had is already in -rc1:
> 
>  b9255850: mm: Adjust do_pages_stat() so gcc can see copy_from_user() is
>  safe
> 
> I've Cc:-ed more folks.
> 

I have verified the build tree and am building from -rc1 only. The fix you've 
mentioned above is also part of it.

debian-build:/tmp/all-yes-config/2.6.33-rc1# cat Makefile |grep EXTRAVERSION
EXTRAVERSION = -rc1

Must be a newer bug then.


Regards,
Ritesh
-- 
Ritesh Raj Sarraf
RESEARCHUT - http://www.researchut.com
"Necessity is the mother of invention."

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: 2.6.33-rc1 build failure: copy_from_user() buffer size is not provably correct

[H. Peter Anvin]

On 12/21/2009 03:09 AM, Ritesh Raj Sarraf wrote:
> 
> I have verified the build tree and am building from -rc1 only. The fix you've 
> mentioned above is also part of it.
> 
> debian-build:/tmp/all-yes-config/2.6.33-rc1# cat Makefile |grep EXTRAVERSION
> EXTRAVERSION = -rc1
> 
> Must be a newer bug then.
> 

No, it's the same one, but different gcc.  Sigh.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

Re: 2.6.33-rc1 build failure: copy_from_user() buffer size is not provably correct

[Arjan van de Ven]

On Mon, 21 Dec 2009 09:18:26 -0800
"H. Peter Anvin" <hpa@zytor.com> wrote:

> On 12/21/2009 03:09 AM, Ritesh Raj Sarraf wrote:
> > 
> > I have verified the build tree and am building from -rc1 only. The
> > fix you've mentioned above is also part of it.
> > 
> > debian-build:/tmp/all-yes-config/2.6.33-rc1# cat Makefile |grep
> > EXTRAVERSION EXTRAVERSION = -rc1
> > 
> > Must be a newer bug then.
> > 
> 
> No, it's the same one, but different gcc.  Sigh.

worth trying the variant I had ;-)

Re: 2.6.33-rc1 build failure: copy_from_user() buffer size is not provably correct

[H. Peter Anvin]

On 12/21/2009 01:13 AM, Ingo Molnar wrote:
> 
> * KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:
> 
>>>                  from mm/migrate.c:15:
>>> In function ???copy_from_user???,
>>>     inlined from ???do_pages_stat??? at mm/migrate.c:1009:
>>> /tmp/all-yes-config/2.6.33-rc1/arch/x86/include/asm/uaccess_32.h:213: error: 
>>> call to ???copy_from_user_overflow??? declared with attribute error: 
>>> copy_from_user() buffer size is not provably correct
>>
>> afaik, ingo already queued this fix.
>> please wait (very) few days.
>>
>> thanks.
> 
> hm, the one mm/migrate.c fix we had is already in -rc1:
> 
>  b9255850: mm: Adjust do_pages_stat() so gcc can see copy_from_user() is safe
> 
> I've Cc:-ed more folks.
> 

That *is* the error report that he is describing.  What version of gcc
is he using?  It might be dumber than the one I have.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

Re: 2.6.33-rc1 build failure: copy_from_user() buffer size is not provably correct

[Ritesh Raj Sarraf]

[-- Attachment #1: Type: Text/Plain, Size: 412 bytes --]

On Monday 21 Dec 2009 22:47:57 H. Peter Anvin wrote:
> > I've Cc:-ed more folks.
> > 
> 
> That is the error report that he is describing.  What version of gcc
> is he using?  It might be dumber than the one I have.
> 
debian-build:~# gcc --version
gcc (Debian 4.4.2-5) 4.4.2


Regards,
Ritesh
-- 
Ritesh Raj Sarraf
RESEARCHUT - http://www.researchut.com
"Necessity is the mother of invention."

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: 2.6.33-rc1 build failure: copy_from_user() buffer size is not provably correct

[KOSAKI Motohiro]

> On 12/21/2009 01:13 AM, Ingo Molnar wrote:
> > 
> > * KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:
> > 
> >>>                  from mm/migrate.c:15:
> >>> In function ???copy_from_user???,
> >>>     inlined from ???do_pages_stat??? at mm/migrate.c:1009:
> >>> /tmp/all-yes-config/2.6.33-rc1/arch/x86/include/asm/uaccess_32.h:213: error: 
> >>> call to ???copy_from_user_overflow??? declared with attribute error: 
> >>> copy_from_user() buffer size is not provably correct
> >>
> >> afaik, ingo already queued this fix.
> >> please wait (very) few days.
> >>
> >> thanks.
> > 
> > hm, the one mm/migrate.c fix we had is already in -rc1:
> > 
> >  b9255850: mm: Adjust do_pages_stat() so gcc can see copy_from_user() is safe
> > 
> > I've Cc:-ed more folks.
> > 
> 
> That *is* the error report that he is describing.  What version of gcc
> is he using?  It might be dumber than the one I have.

I was also successed build.

my environment is here:

	2.6.33-rc1
	CONFIG_DEBUG_STRICT_USER_COPY_CHECKS=y
	gcc version 4.4.2 20091027 (Red Hat 4.4.2-7) (GCC)

I'm amazing (?_?)