From: bonzini@gnu.org (Paolo Bonzini)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Convert BUG() to use unreachable()
Date: Tue, 22 Dec 2009 12:33:34 +0100 [thread overview]
Message-ID: <4B30AE8E.8060805@gnu.org> (raw)
In-Reply-To: <84fc9c000912170917y4b2772d0n47bb4dabc74b91ef@mail.gmail.com>
On 12/17/2009 06:17 PM, Richard Guenther wrote:
> It shouldn't as *(int *)0 = 0; might trap. But if you want to be sure
> use
> __builtin_trap ();
> instead for the whole sequence (the unreachable is implied then).
> GCC choses a size-optimal trap representation for your target then.
Agree that it shouldn't but just to be sure I'd use
*(volatile int *)0 = 0;
unreachable ();
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <bonzini@gnu.org>
To: Richard Guenther <richard.guenther@gmail.com>
Cc: "David Daney" <ddaney@caviumnetworks.com>,
"Jamie Lokier" <jamie@shareable.org>,
"gcc@gcc.gnu.org" <gcc@gcc.gnu.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: Convert BUG() to use unreachable()
Date: Tue, 22 Dec 2009 12:33:34 +0100 [thread overview]
Message-ID: <4B30AE8E.8060805@gnu.org> (raw)
In-Reply-To: <84fc9c000912170917y4b2772d0n47bb4dabc74b91ef@mail.gmail.com>
On 12/17/2009 06:17 PM, Richard Guenther wrote:
> It shouldn't as *(int *)0 = 0; might trap. But if you want to be sure
> use
> __builtin_trap ();
> instead for the whole sequence (the unreachable is implied then).
> GCC choses a size-optimal trap representation for your target then.
Agree that it shouldn't but just to be sure I'd use
*(volatile int *)0 = 0;
unreachable ();
Paolo
next prev parent reply other threads:[~2009-12-22 11:33 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-08 9:55 [PATCH] ARM: Convert BUG() to use unreachable() Uwe Kleine-König
2009-12-08 9:55 ` Uwe Kleine-König
2009-12-08 17:07 ` David Daney
2009-12-10 17:50 ` Russell King - ARM Linux
2009-12-10 17:50 ` Russell King - ARM Linux
2009-12-10 17:55 ` David Daney
2009-12-16 13:58 ` Uwe Kleine-König
2009-12-16 13:58 ` Uwe Kleine-König
2009-12-17 15:01 ` Jamie Lokier
2009-12-17 15:01 ` Jamie Lokier
2009-12-17 17:09 ` David Daney
2009-12-17 17:17 ` Richard Guenther
2009-12-17 17:17 ` Richard Guenther
2009-12-17 18:17 ` Russell King - ARM Linux
2009-12-17 18:17 ` Russell King - ARM Linux
2009-12-17 18:35 ` Joe Buck
2009-12-17 18:35 ` Joe Buck
2009-12-17 19:06 ` Russell King - ARM Linux
2009-12-17 19:06 ` Russell King - ARM Linux
2009-12-17 19:14 ` Joe Buck
2009-12-17 19:14 ` Joe Buck
2009-12-17 19:33 ` David Daney
2009-12-17 19:33 ` Russell King - ARM Linux
2009-12-17 19:33 ` Russell King - ARM Linux
2009-12-17 19:38 ` Jamie Lokier
2009-12-17 19:38 ` Jamie Lokier
2009-12-17 19:48 ` Russell King - ARM Linux
2009-12-17 19:48 ` Russell King - ARM Linux
2009-12-17 19:58 ` Russell King - ARM Linux
2009-12-17 19:58 ` Russell King - ARM Linux
2009-12-17 19:04 ` Jamie Lokier
2009-12-17 19:04 ` Jamie Lokier
2009-12-21 19:30 ` Richard Henderson
2009-12-21 19:30 ` Richard Henderson
2009-12-21 20:10 ` Russell King - ARM Linux
2009-12-21 20:10 ` Russell King - ARM Linux
2009-12-22 14:09 ` Dave Korn
2009-12-22 14:09 ` Dave Korn
2009-12-22 14:12 ` Russell King - ARM Linux
2009-12-22 14:12 ` Russell King - ARM Linux
2009-12-22 14:49 ` Dave Korn
2009-12-22 14:49 ` Dave Korn
2009-12-22 11:33 ` Paolo Bonzini [this message]
2009-12-22 11:33 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B30AE8E.8060805@gnu.org \
--to=bonzini@gnu.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.