All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dirk Behme <dirk.behme@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] omap3: beagle: fix compile error
Date: Thu, 24 Dec 2009 07:13:59 +0100	[thread overview]
Message-ID: <4B3306A7.5010409@googlemail.com> (raw)
In-Reply-To: <1261580085-22547-1-git-send-email-premi@ti.com>

On 23.12.2009 15:54, Sanjeev Premi wrote:
> The configuration for beagle undefs CONFIG_CMD_NET.
> This leads to following error:
>
> lib_arm/libarm.a(board.o): In function `start_armboot':
> /home/premi/u-boot/lib_arm/board.c:360: undefined reference
>   to `getenv_IPaddr'
> make: *** [u-boot] Error 1
>
> This patch fixes the error by including offending line
> in appropriate ifdef.
>
> Signed-off-by: Sanjeev Premi<premi@ti.com>

Acked-by: Dirk Behme <dirk.behme@googlemail.com>

Tom: Could we get this applied and sent to Wolfgang asap? Mainline 
Beagle, Pandora, Zoom1and Zoom2 are broken without this.

Best regards

Dirk

> ---
>   lib_arm/board.c |    3 ++-
>   1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/lib_arm/board.c b/lib_arm/board.c
> index e148739..e289fc9 100644
> --- a/lib_arm/board.c
> +++ b/lib_arm/board.c
> @@ -357,8 +357,9 @@ void start_armboot (void)
>   #endif
>
>   	/* IP Address */
> +#ifdef CONFIG_CMD_NET
>   	gd->bd->bi_ip_addr = getenv_IPaddr ("ipaddr");
> -
> +#endif
>   	stdio_init ();	/* get the devices list going. */
>
>   	jumptable_init ();

  reply	other threads:[~2009-12-24  6:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-23 14:54 [U-Boot] [PATCH] omap3: beagle: fix compile error Sanjeev Premi
2009-12-24  6:13 ` Dirk Behme [this message]
2009-12-25 23:33   ` Wolfgang Denk
2009-12-26  8:08     ` Dirk Behme
2009-12-28 19:38       ` Wolfgang Denk
2009-12-25 23:33 ` Wolfgang Denk
2009-12-28 12:42   ` Premi, Sanjeev
2009-12-28 19:34     ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B3306A7.5010409@googlemail.com \
    --to=dirk.behme@googlemail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.