All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dirk Behme <dirk.behme@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] omap3: beagle: fix compile error
Date: Sat, 26 Dec 2009 09:08:59 +0100	[thread overview]
Message-ID: <4B35C49B.4090602@googlemail.com> (raw)
In-Reply-To: <20091225233347.7DFC624F20@gemini.denx.de>

Dear Wolfgang Denk,

On 26.12.2009 00:33, Wolfgang Denk wrote:
> Dear Dirk Behme,
>
> In message<4B3306A7.5010409@googlemail.com>  you wrote:
>> On 23.12.2009 15:54, Sanjeev Premi wrote:
>>> The configuration for beagle undefs CONFIG_CMD_NET.
>>> This leads to following error:
>>>
>>> lib_arm/libarm.a(board.o): In function `start_armboot':
>>> /home/premi/u-boot/lib_arm/board.c:360: undefined reference
>>>    to `getenv_IPaddr'
>>> make: *** [u-boot] Error 1
>>>
>>> This patch fixes the error by including offending line
>>> in appropriate ifdef.
>>>
>>> Signed-off-by: Sanjeev Premi<premi@ti.com>
>>
>> Acked-by: Dirk Behme<dirk.behme@googlemail.com>
>>
>> Tom: Could we get this applied and sent to Wolfgang asap? Mainline
>> Beagle, Pandora, Zoom1and Zoom2 are broken without this.
>
> Sorry, but I disagree.

I hope you only disagree on the fix Sanjeev (and others, see below) 
proposed? And not that it should be fixed asap?

Please note that other architectures (not only boards) seem to have 
the same issue

http://lists.denx.de/pipermail/u-boot/2009-December/065810.html

Regarding your proposal to implement getenv_IPaddr() for all 
architectures
independent of CONFIG_NET

http://lists.denx.de/pipermail/u-boot/2009-December/065833.html

do you have a proposal where (in which file) this should be done? 
Sounds like it has to be a global function available for all 
architectures?

Best regards

Dirk

  reply	other threads:[~2009-12-26  8:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-23 14:54 [U-Boot] [PATCH] omap3: beagle: fix compile error Sanjeev Premi
2009-12-24  6:13 ` Dirk Behme
2009-12-25 23:33   ` Wolfgang Denk
2009-12-26  8:08     ` Dirk Behme [this message]
2009-12-28 19:38       ` Wolfgang Denk
2009-12-25 23:33 ` Wolfgang Denk
2009-12-28 12:42   ` Premi, Sanjeev
2009-12-28 19:34     ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B35C49B.4090602@googlemail.com \
    --to=dirk.behme@googlemail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.