* [Patch] console: limit the range of VGACON_SOFT_SCROLLBACK_SIZE
@ 2009-12-25 2:40 Amerigo Wang
2009-12-25 2:46 ` Cong Wang
2009-12-25 13:59 ` BuraphaLinux Server
0 siblings, 2 replies; 3+ messages in thread
From: Amerigo Wang @ 2009-12-25 2:40 UTC (permalink / raw)
To: linux-kernel; +Cc: akpm, Amerigo Wang, David S. Miller
BuraphaLinux reported that we will trigger a mm warning when
we CONFIG_VGACON_SOFT_SCROLLBACK_SIZE=65536, this is because
mm cann't allocate so many pages. We should limit the range
of CONFIG_VGACON_SOFT_SCROLLBACK_SIZE, don't give a user
any chance to trigger that.
Reported-by: BuraphaLinux Server <buraphalinuxserver@gmail.com>
Signed-off-by: WANG Cong <amwang@redhat.com>
Cc: David S. Miller <davem@davemloft.net>
---
diff --git a/drivers/video/console/Kconfig b/drivers/video/console/Kconfig
index fc7d9bb..8e8f18d 100644
--- a/drivers/video/console/Kconfig
+++ b/drivers/video/console/Kconfig
@@ -37,6 +37,7 @@ config VGACON_SOFT_SCROLLBACK
config VGACON_SOFT_SCROLLBACK_SIZE
int "Scrollback Buffer Size (in KB)"
depends on VGACON_SOFT_SCROLLBACK
+ range 1 1024
default "64"
help
Enter the amount of System RAM to allocate for the scrollback
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Patch] console: limit the range of VGACON_SOFT_SCROLLBACK_SIZE
2009-12-25 2:40 [Patch] console: limit the range of VGACON_SOFT_SCROLLBACK_SIZE Amerigo Wang
@ 2009-12-25 2:46 ` Cong Wang
2009-12-25 13:59 ` BuraphaLinux Server
1 sibling, 0 replies; 3+ messages in thread
From: Cong Wang @ 2009-12-25 2:46 UTC (permalink / raw)
To: linux-kernel
Cc: akpm, David S. Miller, BuraphaLinux Server, Justin P. Mattock,
Randy Dunlap
Adding some Cc's in the original thread. :)
Amerigo Wang wrote:
> BuraphaLinux reported that we will trigger a mm warning when
> we CONFIG_VGACON_SOFT_SCROLLBACK_SIZE=65536, this is because
> mm cann't allocate so many pages. We should limit the range
> of CONFIG_VGACON_SOFT_SCROLLBACK_SIZE, don't give a user
> any chance to trigger that.
>
> Reported-by: BuraphaLinux Server <buraphalinuxserver@gmail.com>
> Signed-off-by: WANG Cong <amwang@redhat.com>
> Cc: David S. Miller <davem@davemloft.net>
>
> ---
> diff --git a/drivers/video/console/Kconfig b/drivers/video/console/Kconfig
> index fc7d9bb..8e8f18d 100644
> --- a/drivers/video/console/Kconfig
> +++ b/drivers/video/console/Kconfig
> @@ -37,6 +37,7 @@ config VGACON_SOFT_SCROLLBACK
> config VGACON_SOFT_SCROLLBACK_SIZE
> int "Scrollback Buffer Size (in KB)"
> depends on VGACON_SOFT_SCROLLBACK
> + range 1 1024
> default "64"
> help
> Enter the amount of System RAM to allocate for the scrollback
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Patch] console: limit the range of VGACON_SOFT_SCROLLBACK_SIZE
2009-12-25 2:40 [Patch] console: limit the range of VGACON_SOFT_SCROLLBACK_SIZE Amerigo Wang
2009-12-25 2:46 ` Cong Wang
@ 2009-12-25 13:59 ` BuraphaLinux Server
1 sibling, 0 replies; 3+ messages in thread
From: BuraphaLinux Server @ 2009-12-25 13:59 UTC (permalink / raw)
To: Amerigo Wang; +Cc: linux-kernel, akpm, David S. Miller
On 12/25/09, Amerigo Wang <amwang@redhat.com> wrote:
>
> BuraphaLinux reported that we will trigger a mm warning when
> we CONFIG_VGACON_SOFT_SCROLLBACK_SIZE=65536, this is because
> mm cann't allocate so many pages. We should limit the range
> of CONFIG_VGACON_SOFT_SCROLLBACK_SIZE, don't give a user
> any chance to trigger that.
>
> Reported-by: John Gatewood Ham <buraphalinuxserver@gmail.com>
> Signed-off-by: WANG Cong <amwang@redhat.com>
> Cc: David S. Miller <davem@davemloft.net>
>
> ---
> diff --git a/drivers/video/console/Kconfig b/drivers/video/console/Kconfig
> index fc7d9bb..8e8f18d 100644
> --- a/drivers/video/console/Kconfig
> +++ b/drivers/video/console/Kconfig
> @@ -37,6 +37,7 @@ config VGACON_SOFT_SCROLLBACK
> config VGACON_SOFT_SCROLLBACK_SIZE
> int "Scrollback Buffer Size (in KB)"
> depends on VGACON_SOFT_SCROLLBACK
> + range 1 1024
> default "64"
> help
> Enter the amount of System RAM to allocate for the scrollback
>
This fixed the problem. Thank you for the fix. I texted on 2.6.32.2
with your patch added, x86_64 kernel.
Tested-by: John Gatewood Ham <buraphalinuxserver@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-12-25 13:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-25 2:40 [Patch] console: limit the range of VGACON_SOFT_SCROLLBACK_SIZE Amerigo Wang
2009-12-25 2:46 ` Cong Wang
2009-12-25 13:59 ` BuraphaLinux Server
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.