From: Li Zefan <lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
To: Ben Blum <bblum-OM76b2Iv3yLQjUSlxSEPGw@public.gmane.org>
Cc: Paul Menage <menage-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org
Subject: Re: [PATCH 1/4] cgroups: revamp subsys array
Date: Mon, 28 Dec 2009 14:29:53 +0800 [thread overview]
Message-ID: <4B385061.9060600@cn.fujitsu.com> (raw)
In-Reply-To: <20091221203515.GB5683-OM76b2Iv3yLQjUSlxSEPGw@public.gmane.org>
> Make subsys[] able to be dynamically populated to support modular subsystems
>
> From: Ben Blum <bblum-OM76b2Iv3yLQjUSlxSEPGw@public.gmane.org>
>
> This patch reworks the way the subsys[] array is used so that subsystems can
> register themselves after boot time, and enables the internals of cgroups to
> be able to handle when subsystems are not present or may appear/disappear.
>
> Signed-off-by: Ben Blum <bblum-OM76b2Iv3yLQjUSlxSEPGw@public.gmane.org>
Acked-by: Li Zefan <lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
...
A small nitpick:
> +/* This define indicates the maximum number of subsystems that can be loaded
> + * at once. We limit to this many since cgroupfs_root has subsys_bits to keep
> + * track of all of them. */
Please always use this style:
/*
* xxx
* xxx
*/
WARNING: multiple messages have this Message-ID (diff)
From: Li Zefan <lizf@cn.fujitsu.com>
To: Ben Blum <bblum@andrew.cmu.edu>
Cc: linux-kernel@vger.kernel.org,
containers@lists.linux-foundation.org, akpm@linux-foundation.org,
Paul Menage <menage@google.com>
Subject: Re: [PATCH 1/4] cgroups: revamp subsys array
Date: Mon, 28 Dec 2009 14:29:53 +0800 [thread overview]
Message-ID: <4B385061.9060600@cn.fujitsu.com> (raw)
In-Reply-To: <20091221203515.GB5683@andrew.cmu.edu>
> Make subsys[] able to be dynamically populated to support modular subsystems
>
> From: Ben Blum <bblum@andrew.cmu.edu>
>
> This patch reworks the way the subsys[] array is used so that subsystems can
> register themselves after boot time, and enables the internals of cgroups to
> be able to handle when subsystems are not present or may appear/disappear.
>
> Signed-off-by: Ben Blum <bblum@andrew.cmu.edu>
Acked-by: Li Zefan <lizf@cn.fujitsu.com>
...
A small nitpick:
> +/* This define indicates the maximum number of subsystems that can be loaded
> + * at once. We limit to this many since cgroupfs_root has subsys_bits to keep
> + * track of all of them. */
Please always use this style:
/*
* xxx
* xxx
*/
next prev parent reply other threads:[~2009-12-28 6:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-21 20:32 [PATCH 0/4] cgroups: support for module-loadable subsystems Ben Blum
2009-12-21 20:35 ` [PATCH 1/4] cgroups: revamp subsys array Ben Blum
[not found] ` <20091221203515.GB5683-OM76b2Iv3yLQjUSlxSEPGw@public.gmane.org>
2009-12-28 6:29 ` Li Zefan [this message]
2009-12-28 6:29 ` Li Zefan
2009-12-21 20:36 ` [PATCH 2/4] cgroups: subsystem module loading interface Ben Blum
2009-12-28 6:32 ` Li Zefan
2009-12-28 12:40 ` Ben Blum
2009-12-29 1:03 ` Li Zefan
[not found] ` <20091228124029.GB4824-OM76b2Iv3yLQjUSlxSEPGw@public.gmane.org>
2009-12-29 1:03 ` Li Zefan
[not found] ` <4B3850F4.4090203-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2009-12-28 12:40 ` Ben Blum
[not found] ` <20091221203613.GC5683-OM76b2Iv3yLQjUSlxSEPGw@public.gmane.org>
2009-12-28 6:32 ` Li Zefan
2009-12-21 20:37 ` [PATCH 3/4] cgroups: net_cls as module Ben Blum
[not found] ` <20091221203704.GD5683-OM76b2Iv3yLQjUSlxSEPGw@public.gmane.org>
2009-12-28 6:34 ` Li Zefan
2009-12-28 6:34 ` Li Zefan
2009-12-28 12:37 ` Ben Blum
[not found] ` <4B385164.9070704-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2009-12-28 12:37 ` Ben Blum
2009-12-21 20:38 ` [PATCH 4/4] cgroups: subsystem module unloading Ben Blum
[not found] ` <20091221203800.GE5683-OM76b2Iv3yLQjUSlxSEPGw@public.gmane.org>
2009-12-28 6:36 ` Li Zefan
2009-12-28 6:36 ` Li Zefan
[not found] ` <20091221203253.GA5683-OM76b2Iv3yLQjUSlxSEPGw@public.gmane.org>
2009-12-21 20:35 ` [PATCH 1/4] cgroups: revamp subsys array Ben Blum
2009-12-21 20:36 ` [PATCH 2/4] cgroups: subsystem module loading interface Ben Blum
2009-12-21 20:37 ` [PATCH 3/4] cgroups: net_cls as module Ben Blum
2009-12-21 20:38 ` [PATCH 4/4] cgroups: subsystem module unloading Ben Blum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B385061.9060600@cn.fujitsu.com \
--to=lizf-bthxqxjhjhxqfuhtdcdx3a@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=bblum-OM76b2Iv3yLQjUSlxSEPGw@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=menage-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.