All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Grégoire Sutre" <gregoire.sutre@labri.fr>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Check for device type (block/character) in grub-setup?
Date: Sun, 03 Jan 2010 03:54:49 +0100	[thread overview]
Message-ID: <4B4006F9.30402@labri.fr> (raw)

Hi,

I'm wondering why there is no check for device type (block/character) in 
grub-setup.c whereas the function probe() in grub-probe.c exits with 
error if the device is not of the expected type. Shouldn't there be a 
similar check in grub-setup?

Currently, on NetBSD (with in-progress patches), grub-setup fails with 
an `out of disk error' on a block device as the detected disk size is 0, 
whereas grub-probe exits gracefully with an error message telling that 
the input device is not a character device.  I guess that a similar 
behavior could be observed on FreeBSD, but I can't actually test this.

Thanks,

Grégoire



             reply	other threads:[~2010-01-03  2:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-03  2:54 Grégoire Sutre [this message]
2010-01-03 16:52 ` Check for device type (block/character) in grub-setup? Robert Millan
2010-01-07 17:31   ` Grégoire Sutre
2010-01-07 19:35     ` Robert Millan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B4006F9.30402@labri.fr \
    --to=gregoire.sutre@labri.fr \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.