All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boaz Harrosh <bharrosh@panasas.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: James Bottomley <James.Bottomley@suse.de>,
	linux-scsi <linux-scsi@vger.kernel.org>,
	open-osd <osd-dev@open-osd.org>,
	Benny Halevy <bhalevy@panasas.com>,
	Stable Tree <stable@kernel.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [osd-dev] [PATCH] scsi_lib: Bug in completion of bidi commands
Date: Sun, 03 Jan 2010 12:11:46 +0200	[thread overview]
Message-ID: <4B406D62.8060500@panasas.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0912312144080.16709-100000@netrider.rowland.org>

On 01/01/2010 04:46 AM, Alan Stern wrote:
> On Thu, 31 Dec 2009, Boaz Harrosh wrote:
> 
>> James hi.
>>
>> What about this BUG. It affects anybody doing bidi commands. The possibilities
>> are an sglist leak at best, and a crash at worse.
>>
>> I understand this code needs cleanup, but first things first. Lets first fix the
>> bug, which should also go to stable. Then the cleanup can go to next merge window.
>>
>> BTW: Should I attempt a cleanup on current code, or should I wait for Alan's Patch
>> to go in first?
> 
> What patch of mine are you referring to?  So far James has rejected all
> the patches I have submitted recently.  I'm going to try again in the 
> near future...
> 

OK, that's my answer, I didn't know.

Would you want that I attempt that collapsing of scsi_end_request() into scsi_io_completion
and the cleanup that implies? (that's the patch I meant.)

> Alan Stern
> 

Thanks && Happy new decade
Boaz

  reply	other threads:[~2010-01-03 10:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-15 15:25 [PATCH] scsi_lib: Bug in completion of bidi commands Boaz Harrosh
2009-12-31  7:53 ` [osd-dev] " Boaz Harrosh
2010-01-01  2:46   ` Alan Stern
2010-01-03 10:11     ` Boaz Harrosh [this message]
2010-01-03 16:55       ` Alan Stern
2010-01-04  7:26         ` Boaz Harrosh
2010-01-12 11:16 ` Boaz Harrosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B406D62.8060500@panasas.com \
    --to=bharrosh@panasas.com \
    --cc=James.Bottomley@suse.de \
    --cc=bhalevy@panasas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=osd-dev@open-osd.org \
    --cc=stable@kernel.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.