Re: [PATCH v3] slab: initialize unused alien cache entry as NULL at alloc_alien_cache().

[Pekka Enberg <penberg@cs.helsinki.fi>]

Haicheng Li kirjoitti:
> Comparing with existing code, it's a simpler way to use kzalloc_node()
> to ensure that each unused alien cache entry is NULL.
> 
> CC: Pekka Enberg <penberg@cs.helsinki.fi>
> CC: Eric Dumazet <eric.dumazet@gmail.com>
> ---
>  mm/slab.c |    6 ++----
>  1 files changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/mm/slab.c b/mm/slab.c
> index 7dfa481..5d1a782 100644
> --- a/mm/slab.c
> +++ b/mm/slab.c
> @@ -971,13 +971,11 @@ static struct array_cache **alloc_alien_cache(int 
> node, int limit, gfp_t gfp)
> 
>      if (limit > 1)
>          limit = 12;
> -    ac_ptr = kmalloc_node(memsize, gfp, node);
> +    ac_ptr = kzalloc_node(memsize, gfp, node);
>      if (ac_ptr) {
>          for_each_node(i) {
> -            if (i == node || !node_online(i)) {
> -                ac_ptr[i] = NULL;
> +            if (i == node || !node_online(i))
>                  continue;
> -            }
>              ac_ptr[i] = alloc_arraycache(node, limit, 0xbaadf00d, gfp);
>              if (!ac_ptr[i]) {
>                  for (i--; i >= 0; i--)

Christoph? Matt?