* [PATCH]drivers/mtd/chips/cfi_probe.c:18 remove unneeded comment
@ 2010-01-07 22:18 ` René Bolldorf
0 siblings, 0 replies; 4+ messages in thread
From: René Bolldorf @ 2010-01-07 22:18 UTC (permalink / raw)
To: David Woodhouse; +Cc: linux-mtd, linux-kernel
--- ./drivers/mtd/chips/cfi_probe.c 2009-12-28 21:09:46.638828686 +0100
+++ ./drivers/mtd/chips/cfi_probe.c 2010-01-04 22:38:31.536678726 +0100
@@ -18,8 +18,6 @@
#include <linux/mtd/cfi.h>
#include <linux/mtd/gen_probe.h>
-//#define DEBUG_CFI
-
#ifdef DEBUG_CFI
static void print_cfi_ident(struct cfi_ident *);
#endif
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH]drivers/mtd/chips/cfi_probe.c:18 remove unneeded comment
@ 2010-01-07 22:18 ` René Bolldorf
0 siblings, 0 replies; 4+ messages in thread
From: René Bolldorf @ 2010-01-07 22:18 UTC (permalink / raw)
To: David Woodhouse; +Cc: linux-kernel, linux-mtd
--- ./drivers/mtd/chips/cfi_probe.c 2009-12-28 21:09:46.638828686 +0100
+++ ./drivers/mtd/chips/cfi_probe.c 2010-01-04 22:38:31.536678726 +0100
@@ -18,8 +18,6 @@
#include <linux/mtd/cfi.h>
#include <linux/mtd/gen_probe.h>
-//#define DEBUG_CFI
-
#ifdef DEBUG_CFI
static void print_cfi_ident(struct cfi_ident *);
#endif
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH]drivers/mtd/chips/cfi_probe.c:18 remove unneeded comment
2010-01-07 22:18 ` René Bolldorf
@ 2010-01-13 5:32 ` Artem Bityutskiy
-1 siblings, 0 replies; 4+ messages in thread
From: Artem Bityutskiy @ 2010-01-13 5:32 UTC (permalink / raw)
To: René Bolldorf; +Cc: linux-mtd, David Woodhouse, linux-kernel
On Thu, 2010-01-07 at 23:18 +0100, René Bolldorf wrote:
> --- ./drivers/mtd/chips/cfi_probe.c 2009-12-28 21:09:46.638828686 +0100
> +++ ./drivers/mtd/chips/cfi_probe.c 2010-01-04 22:38:31.536678726 +0100
> @@ -18,8 +18,6 @@
> #include <linux/mtd/cfi.h>
> #include <linux/mtd/gen_probe.h>
>
> -//#define DEBUG_CFI
> -
> #ifdef DEBUG_CFI
> static void print_cfi_ident(struct cfi_ident *);
> #endif
I do not think this is is needed. The commented out define shows what
one should do to debug the thing. Without that line it is not so
obvious. So, nack from me.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH]drivers/mtd/chips/cfi_probe.c:18 remove unneeded comment
@ 2010-01-13 5:32 ` Artem Bityutskiy
0 siblings, 0 replies; 4+ messages in thread
From: Artem Bityutskiy @ 2010-01-13 5:32 UTC (permalink / raw)
To: René Bolldorf; +Cc: David Woodhouse, linux-kernel, linux-mtd
On Thu, 2010-01-07 at 23:18 +0100, René Bolldorf wrote:
> --- ./drivers/mtd/chips/cfi_probe.c 2009-12-28 21:09:46.638828686 +0100
> +++ ./drivers/mtd/chips/cfi_probe.c 2010-01-04 22:38:31.536678726 +0100
> @@ -18,8 +18,6 @@
> #include <linux/mtd/cfi.h>
> #include <linux/mtd/gen_probe.h>
>
> -//#define DEBUG_CFI
> -
> #ifdef DEBUG_CFI
> static void print_cfi_ident(struct cfi_ident *);
> #endif
I do not think this is is needed. The commented out define shows what
one should do to debug the thing. Without that line it is not so
obvious. So, nack from me.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-01-13 5:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-07 22:18 [PATCH]drivers/mtd/chips/cfi_probe.c:18 remove unneeded comment René Bolldorf
2010-01-07 22:18 ` René Bolldorf
2010-01-13 5:32 ` Artem Bityutskiy
2010-01-13 5:32 ` Artem Bityutskiy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.