[PATCH] ARCH OMAP : enable ARCH_HAS_HOLES_MEMORYMODEL for OMAP

[PATCH] ARCH OMAP : enable ARCH_HAS_HOLES_MEMORYMODEL for OMAP

[Sriramakrishnan]

From: Sriram <srk@ti.com>

OMAP platforms(like OMAP3530) include DSP or other co-processors
for media acceleration. when carving out memory for the
accelerators we can end up creating a hole in the memory map
of sort:
<kernel memory><hole(memory for accelerator)><kernel memory>

To handle such a memory configuration ARCH_HAS_HOLES_MEMORYMODEL
has to be enabled. For further information refer discussion at:
http://www.mail-archive.com/linux-omap@vger.kernl.org/msg15262.html.

Signed-off-by: Sriramakrishnan <srk@ti.com>
---
 arch/arm/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 5e0bcc5..88f628b 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -699,6 +699,7 @@ config ARCH_OMAP
 	select ARCH_HAS_CPUFREQ
 	select GENERIC_TIME
 	select GENERIC_CLOCKEVENTS
+	select ARCH_HAS_HOLES_MEMORYMODEL
 	help
 	  Support for TI's OMAP platform (OMAP1 and OMAP2).
 
-- 
1.6.2.4

Re: [PATCH] ARCH OMAP : enable ARCH_HAS_HOLES_MEMORYMODEL for OMAP

[Nishanth Menon]

Govindarajan, Sriramakrishnan had written, on 01/07/2010 06:30 AM, the 
following:
> From: Sriram <srk@ti.com>
> 
> OMAP platforms(like OMAP3530) include DSP or other co-processors
> for media acceleration. when carving out memory for the
> accelerators we can end up creating a hole in the memory map
> of sort:
> <kernel memory><hole(memory for accelerator)><kernel memory>
> 
> To handle such a memory configuration ARCH_HAS_HOLES_MEMORYMODEL
> has to be enabled. For further information refer discussion at:
> http://www.mail-archive.com/linux-omap@vger.kernl.org/msg15262.html.

pls check the link: I see "The document you were looking for was not found."
> 
> Signed-off-by: Sriramakrishnan <srk@ti.com>
> ---
>  arch/arm/Kconfig |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 5e0bcc5..88f628b 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -699,6 +699,7 @@ config ARCH_OMAP
>  	select ARCH_HAS_CPUFREQ
>  	select GENERIC_TIME
>  	select GENERIC_CLOCKEVENTS
> +	select ARCH_HAS_HOLES_MEMORYMODEL
why enable this for all OMAPs?
>  	help
>  	  Support for TI's OMAP platform (OMAP1 and OMAP2).
>  


-- 
Regards,
Nishanth Menon

RE: [PATCH] ARCH OMAP : enable ARCH_HAS_HOLES_MEMORYMODEL for OMAP

[Govindarajan, Sriramakrishnan]

> From: Menon, Nishanth
> Govindarajan, Sriramakrishnan had written, on 01/07/2010 06:30 AM, the
> following:
> > From: Sriram <srk@ti.com>
> >
> > OMAP platforms(like OMAP3530) include DSP or other co-processors
> > for media acceleration. when carving out memory for the
> > accelerators we can end up creating a hole in the memory map
> > of sort:
> > <kernel memory><hole(memory for accelerator)><kernel memory>
> >
> > To handle such a memory configuration ARCH_HAS_HOLES_MEMORYMODEL
> > has to be enabled. For further information refer discussion at:
> > http://www.mail-archive.com/linux-omap@vger.kernl.org/msg15262.html.
> 
> pls check the link: I see "The document you were looking for was not
> found."

The URL is spelt incorrectly. Here is the correct URL:
http://www.mail-archive.com/linux-omap@vger.kernel.org/msg15262.html

> >  	select GENERIC_TIME
> >  	select GENERIC_CLOCKEVENTS
> > +	select ARCH_HAS_HOLES_MEMORYMODEL
> why enable this for all OMAPs?

I have tested this on several OMAP3 platforms and this feature is required
Wherever some memory needs to be reserved for media accelerators - hence it
Would be handy for earlier OMAP platforms as well

Regards
Sriram

Re: [PATCH] ARCH OMAP : enable ARCH_HAS_HOLES_MEMORYMODEL for OMAP

[Nishanth Menon]

Govindarajan, Sriramakrishnan had written, on 01/08/2010 02:15 AM, the 
following:
> 
>> From: Menon, Nishanth
>> Govindarajan, Sriramakrishnan had written, on 01/07/2010 06:30 AM, the
>> following:
>>> From: Sriram <srk@ti.com>
>>>
>>> OMAP platforms(like OMAP3530) include DSP or other co-processors
>>> for media acceleration. when carving out memory for the
>>> accelerators we can end up creating a hole in the memory map
>>> of sort:
>>> <kernel memory><hole(memory for accelerator)><kernel memory>
>>>
>>> To handle such a memory configuration ARCH_HAS_HOLES_MEMORYMODEL
>>> has to be enabled. For further information refer discussion at:
>>> http://www.mail-archive.com/linux-omap@vger.kernl.org/msg15262.html.
>> pls check the link: I see "The document you were looking for was not
>> found."
> 
> The URL is spelt incorrectly. Here is the correct URL:
> http://www.mail-archive.com/linux-omap@vger.kernel.org/msg15262.html
> 
>>>  	select GENERIC_TIME
>>>  	select GENERIC_CLOCKEVENTS
>>> +	select ARCH_HAS_HOLES_MEMORYMODEL
>> why enable this for all OMAPs?
> 
> I have tested this on several OMAP3 platforms and this feature is required
> Wherever some memory needs to be reserved for media accelerators - hence it
> Would be handy for earlier OMAP platforms as well
I understand that you have tested with OMAP3. my question is you have 
handled this as per the diff
@@ -699,6 +699,7 @@ config ARCH_OMAP
to ARCH_OMAP

is this good for OMAP1510, 1610, 1710, 2420,2430, 770 etc..?

if this is an OMAP3 requirement why not add it there?
-- 
Regards,
Nishanth Menon

RE: [PATCH] ARCH OMAP : enable ARCH_HAS_HOLES_MEMORYMODEL for OMAP

[Govindarajan, Sriramakrishnan]

From: Menon, Nishanth
> Sent: Friday, January 08, 2010 8:33 PM
> To: Govindarajan, Sriramakrishnan
> Cc: linux-omap@vger.kernel.org; Syed Mohammed, Khasim; Nori, Sekhar
> Subject: Re: [PATCH] ARCH OMAP : enable ARCH_HAS_HOLES_MEMORYMODEL for
> OMAP
> 
> Govindarajan, Sriramakrishnan had written, on 01/08/2010 02:15 AM, the
> following:
> >
> >> From: Menon, Nishanth
> >> Govindarajan, Sriramakrishnan had written, on 01/07/2010 06:30 AM, the
> >> following:
> >>> From: Sriram <srk@ti.com>
> >>>
> >>> OMAP platforms(like OMAP3530) include DSP or other co-processors
> >>> for media acceleration. when carving out memory for the
> >>> accelerators we can end up creating a hole in the memory map
> >>> of sort:
> >>> <kernel memory><hole(memory for accelerator)><kernel memory>
> >>>
> >>> To handle such a memory configuration ARCH_HAS_HOLES_MEMORYMODEL
> >>> has to be enabled. For further information refer discussion at:
> >>> http://www.mail-archive.com/linux-omap@vger.kernl.org/msg15262.html.
> >> pls check the link: I see "The document you were looking for was not
> >> found."
> >
> > The URL is spelt incorrectly. Here is the correct URL:
> > http://www.mail-archive.com/linux-omap@vger.kernel.org/msg15262.html
> >
> >>>  	select GENERIC_TIME
> >>>  	select GENERIC_CLOCKEVENTS
> >>> +	select ARCH_HAS_HOLES_MEMORYMODEL
> >> why enable this for all OMAPs?
> >
> > I have tested this on several OMAP3 platforms and this feature is
> required
> > Wherever some memory needs to be reserved for media accelerators - hence
> it
> > Would be handy for earlier OMAP platforms as well
> I understand that you have tested with OMAP3. my question is you have
> handled this as per the diff
> @@ -699,6 +699,7 @@ config ARCH_OMAP
> to ARCH_OMAP
> 
> is this good for OMAP1510, 1610, 1710, 2420,2430, 770 etc..?

I do not have other OMAP platforms for me to validate this patch on.
I believe the nature of change is generic and benefit other OMAP
Platforms as well.

Regards
Sriram

Re: [PATCH] ARCH OMAP : enable ARCH_HAS_HOLES_MEMORYMODEL for OMAP

[Tony Lindgren]

* Govindarajan, Sriramakrishnan <srk@ti.com> [100111 04:11]:
> From: Menon, Nishanth
> > Sent: Friday, January 08, 2010 8:33 PM
> > To: Govindarajan, Sriramakrishnan
> > Cc: linux-omap@vger.kernel.org; Syed Mohammed, Khasim; Nori, Sekhar
> > Subject: Re: [PATCH] ARCH OMAP : enable ARCH_HAS_HOLES_MEMORYMODEL for
> > OMAP
> > 
> > Govindarajan, Sriramakrishnan had written, on 01/08/2010 02:15 AM, the
> > following:
> > >
> > >> From: Menon, Nishanth
> > >> Govindarajan, Sriramakrishnan had written, on 01/07/2010 06:30 AM, the
> > >> following:
> > >>> From: Sriram <srk@ti.com>
> > >>>
> > >>> OMAP platforms(like OMAP3530) include DSP or other co-processors
> > >>> for media acceleration. when carving out memory for the
> > >>> accelerators we can end up creating a hole in the memory map
> > >>> of sort:
> > >>> <kernel memory><hole(memory for accelerator)><kernel memory>
> > >>>
> > >>> To handle such a memory configuration ARCH_HAS_HOLES_MEMORYMODEL
> > >>> has to be enabled. For further information refer discussion at:
> > >>> http://www.mail-archive.com/linux-omap@vger.kernl.org/msg15262.html.
> > >> pls check the link: I see "The document you were looking for was not
> > >> found."
> > >
> > > The URL is spelt incorrectly. Here is the correct URL:
> > > http://www.mail-archive.com/linux-omap@vger.kernel.org/msg15262.html
> > >
> > >>>  	select GENERIC_TIME
> > >>>  	select GENERIC_CLOCKEVENTS
> > >>> +	select ARCH_HAS_HOLES_MEMORYMODEL
> > >> why enable this for all OMAPs?
> > >
> > > I have tested this on several OMAP3 platforms and this feature is
> > required
> > > Wherever some memory needs to be reserved for media accelerators - hence
> > it
> > > Would be handy for earlier OMAP platforms as well
> > I understand that you have tested with OMAP3. my question is you have
> > handled this as per the diff
> > @@ -699,6 +699,7 @@ config ARCH_OMAP
> > to ARCH_OMAP
> > 
> > is this good for OMAP1510, 1610, 1710, 2420,2430, 770 etc..?
> 
> I do not have other OMAP platforms for me to validate this patch on.
> I believe the nature of change is generic and benefit other OMAP
> Platforms as well.

Sounds like the issue is a slight performance penalty when not used.
But considering all the coprocessors, I'd say let's apply this so
the checks are in place when using the coprocessors.

Regards,

Tony

[APPLIED] > [PATCH] ARCH OMAP : enable ARCH_HAS_HOLES_MEMORYMODEL for

[Tony Lindgren]

This patch has been applied to the linux-omap
by youw fwiendly patch wobot.

Branch in linux-omap: for-next

Initial commit ID (Likely to change): 0824be87f0fea5f4be0c5fd9effc337c0741a9d6

PatchWorks
http://patchwork.kernel.org/patch/71579/

Git (Likely to change, and takes a while to get mirrored)
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=0824be87f0fea5f4be0c5fd9effc337c0741a9d6