All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 2/5] input: make Open Firmware device id constant
@ 2010-01-09 12:55 Németh Márton
  0 siblings, 0 replies; only message in thread
From: Németh Márton @ 2010-01-09 12:55 UTC (permalink / raw)
  To: Dmitry Torokhov; +Cc: linux-input, LKML

From: Márton Németh <nm127@freemail.hu>

The match_table field of the struct of_device_id is constant in <linux/of_platform.h>
so it is worth to make xps2_of_match also constant.

The semantic match that finds this kind of pattern is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r@
disable decl_init,const_decl_init;
identifier I1, I2, x;
@@
	struct I1 {
	  ...
	  const struct I2 *x;
	  ...
	};
@s@
identifier r.I1, y;
identifier r.x, E;
@@
	struct I1 y = {
	  .x = E,
	};
@c@
identifier r.I2;
identifier s.E;
@@
	const struct I2 E[] = ... ;
@depends on !c@
identifier r.I2;
identifier s.E;
@@
+	const
	struct I2 E[] = ...;
// </smpl>

Signed-off-by: Márton Németh <nm127@freemail.hu>
Cc: Julia Lawall <julia@diku.dk>
Cc: cocci@diku.dk
---
diff -u -p a/drivers/input/serio/xilinx_ps2.c b/drivers/input/serio/xilinx_ps2.c
--- a/drivers/input/serio/xilinx_ps2.c 2009-12-03 04:51:21.000000000 +0100
+++ b/drivers/input/serio/xilinx_ps2.c 2010-01-08 19:13:45.000000000 +0100
@@ -354,7 +354,7 @@ static int __devexit xps2_of_remove(stru
 }

 /* Match table for of_platform binding */
-static struct of_device_id xps2_of_match[] __devinitdata = {
+static const struct of_device_id xps2_of_match[] __devinitconst = {
 	{ .compatible = "xlnx,xps-ps2-1.00.a", },
 	{ /* end of list */ },
 };

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2010-01-09 12:55 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-09 12:55 [PATCH 2/5] input: make Open Firmware device id constant Németh Márton

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.