* [PATCH 2/5] block: make USB device id constant
@ 2010-01-10 12:39 Németh Márton
0 siblings, 0 replies; only message in thread
From: Németh Márton @ 2010-01-10 12:39 UTC (permalink / raw)
To: Jens Axboe; +Cc: LKML, Julia Lawall, cocci
From: Márton Németh <nm127@freemail.hu>
The id_table field of the struct usb_device_id is constant in <linux/usb.h>
so it is worth to make ub_usb_ids also constant.
The semantic match that finds this kind of pattern is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
disable decl_init,const_decl_init;
identifier I1, I2, x;
@@
struct I1 {
...
const struct I2 *x;
...
};
@s@
identifier r.I1, y;
identifier r.x, E;
@@
struct I1 y = {
.x = E,
};
@c@
identifier r.I2;
identifier s.E;
@@
const struct I2 E[] = ... ;
@depends on !c@
identifier r.I2;
identifier s.E;
@@
+ const
struct I2 E[] = ...;
// </smpl>
Signed-off-by: Márton Németh <nm127@freemail.hu>
Cc: Julia Lawall <julia@diku.dk>
Cc: cocci@diku.dk
---
diff -u -p a/drivers/block/ub.c b/drivers/block/ub.c
--- a/drivers/block/ub.c 2009-12-03 04:51:21.000000000 +0100
+++ b/drivers/block/ub.c 2010-01-08 09:14:49.000000000 +0100
@@ -393,7 +393,7 @@ static int ub_probe_lun(struct ub_dev *s
#define ub_usb_ids usb_storage_usb_ids
#else
-static struct usb_device_id ub_usb_ids[] = {
+static const struct usb_device_id ub_usb_ids[] = {
{ USB_INTERFACE_INFO(USB_CLASS_MASS_STORAGE, US_SC_SCSI, US_PR_BULK) },
{ }
};
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2010-01-10 12:39 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-10 12:39 [PATCH 2/5] block: make USB device id constant Németh Márton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.