All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 4/5] block: make xenbus device id constant
@ 2010-01-10 12:39 Németh Márton
  0 siblings, 0 replies; only message in thread
From: Németh Márton @ 2010-01-10 12:39 UTC (permalink / raw)
  To: Jens Axboe; +Cc: LKML, Julia Lawall, cocci

From: Márton Németh <nm127@freemail.hu>

The ids field of the struct xenbus_device_id is constant in <linux/xen/xenbus.h>
so it is worth to make blkfront_ids also constant.

The semantic match that finds this kind of pattern is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r@
disable decl_init,const_decl_init;
identifier I1, I2, x;
@@
	struct I1 {
	  ...
	  const struct I2 *x;
	  ...
	};
@s@
identifier r.I1, y;
identifier r.x, E;
@@
	struct I1 y = {
	  .x = E,
	};
@c@
identifier r.I2;
identifier s.E;
@@
	const struct I2 E[] = ... ;
@depends on !c@
identifier r.I2;
identifier s.E;
@@
+	const
	struct I2 E[] = ...;
// </smpl>

Signed-off-by: Márton Németh <nm127@freemail.hu>
Cc: Julia Lawall <julia@diku.dk>
Cc: cocci@diku.dk
---
diff -u -p a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
--- a/drivers/block/xen-blkfront.c 2010-01-07 19:08:39.000000000 +0100
+++ b/drivers/block/xen-blkfront.c 2010-01-08 09:28:49.000000000 +0100
@@ -1050,7 +1050,7 @@ static const struct block_device_operati
 };


-static struct xenbus_device_id blkfront_ids[] = {
+static const struct xenbus_device_id blkfront_ids[] = {
 	{ "vbd" },
 	{ "" }
 };

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2010-01-10 12:40 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-10 12:39 [PATCH 4/5] block: make xenbus device id constant Németh Márton

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.