All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 5/5] block: make virtio device id constant
@ 2010-01-10 12:40 Németh Márton
  0 siblings, 0 replies; only message in thread
From: Németh Márton @ 2010-01-10 12:40 UTC (permalink / raw)
  To: Jens Axboe; +Cc: LKML, Julia Lawall, cocci

From: Márton Németh <nm127@freemail.hu>

The id_table field of the struct virtio_driver is constant in <linux/virtio.h>
so it is worth to make id_table also constant.

The semantic match that finds this kind of pattern is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r@
disable decl_init,const_decl_init;
identifier I1, I2, x;
@@
	struct I1 {
	  ...
	  const struct I2 *x;
	  ...
	};
@s@
identifier r.I1, y;
identifier r.x, E;
@@
	struct I1 y = {
	  .x = E,
	};
@c@
identifier r.I2;
identifier s.E;
@@
	const struct I2 E[] = ... ;
@depends on !c@
identifier r.I2;
identifier s.E;
@@
+	const
	struct I2 E[] = ...;
// </smpl>

Signed-off-by: Márton Németh <nm127@freemail.hu>
Cc: Julia Lawall <julia@diku.dk>
Cc: cocci@diku.dk
---
diff -u -p a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
--- a/drivers/block/virtio_blk.c 2009-12-03 04:51:21.000000000 +0100
+++ b/drivers/block/virtio_blk.c 2010-01-08 09:30:00.000000000 +0100
@@ -404,7 +404,7 @@ static void __devexit virtblk_remove(str
 	kfree(vblk);
 }

-static struct virtio_device_id id_table[] = {
+static const struct virtio_device_id id_table[] = {
 	{ VIRTIO_ID_BLOCK, VIRTIO_DEV_ANY_ID },
 	{ 0 },
 };

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2010-01-10 12:40 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-10 12:40 [PATCH 5/5] block: make virtio device id constant Németh Márton

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.