All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Németh Márton" <nm127@freemail.hu>
To: linux-serial@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>, cocci@diku.dk
Subject: [PATCH 2/3] serial: make dio device id constant
Date: Sun, 10 Jan 2010 17:59:36 +0100	[thread overview]
Message-ID: <4B4A0778.2000508@freemail.hu> (raw)

From: Márton Németh <nm127@freemail.hu>

The id_table field of the struct dio_driver is constant in <linux/dio.h>
so it is worth to make the initialization data also constant.

The semantic match that finds this kind of pattern is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r@
disable decl_init,const_decl_init;
identifier I1, I2, x;
@@
	struct I1 {
	  ...
	  const struct I2 *x;
	  ...
	};
@s@
identifier r.I1, y;
identifier r.x, E;
@@
	struct I1 y = {
	  .x = E,
	};
@c@
identifier r.I2;
identifier s.E;
@@
	const struct I2 E[] = ... ;
@depends on !c@
identifier r.I2;
identifier s.E;
@@
+	const
	struct I2 E[] = ...;
// </smpl>

Signed-off-by: Márton Németh <nm127@freemail.hu>
Cc: Julia Lawall <julia@diku.dk>
Cc: cocci@diku.dk
---
diff -u -p a/drivers/serial/8250_hp300.c b/drivers/serial/8250_hp300.c
--- a/drivers/serial/8250_hp300.c 2009-12-03 04:51:21.000000000 +0100
+++ b/drivers/serial/8250_hp300.c 2010-01-08 18:52:23.000000000 +0100
@@ -39,7 +39,7 @@ static int __devinit hpdca_init_one(stru
 					const struct dio_device_id *ent);
 static void __devexit hpdca_remove_one(struct dio_dev *d);

-static struct dio_device_id hpdca_dio_tbl[] = {
+static const struct dio_device_id hpdca_dio_tbl[] = {
 	{ DIO_ID_DCA0 },
 	{ DIO_ID_DCA0REM },
 	{ DIO_ID_DCA1 },
_______________________________________________
Cocci mailing list
Cocci@diku.dk
http://lists.diku.dk/mailman/listinfo/cocci
(Web access from inside DIKUs LAN only)

WARNING: multiple messages have this Message-ID (diff)
From: "Németh Márton" <nm127@freemail.hu>
To: linux-serial@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>, Julia Lawall <julia@diku.dk>,
	cocci@diku.dk
Subject: [PATCH 2/3] serial: make dio device id constant
Date: Sun, 10 Jan 2010 17:59:36 +0100	[thread overview]
Message-ID: <4B4A0778.2000508@freemail.hu> (raw)

From: Márton Németh <nm127@freemail.hu>

The id_table field of the struct dio_driver is constant in <linux/dio.h>
so it is worth to make the initialization data also constant.

The semantic match that finds this kind of pattern is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r@
disable decl_init,const_decl_init;
identifier I1, I2, x;
@@
	struct I1 {
	  ...
	  const struct I2 *x;
	  ...
	};
@s@
identifier r.I1, y;
identifier r.x, E;
@@
	struct I1 y = {
	  .x = E,
	};
@c@
identifier r.I2;
identifier s.E;
@@
	const struct I2 E[] = ... ;
@depends on !c@
identifier r.I2;
identifier s.E;
@@
+	const
	struct I2 E[] = ...;
// </smpl>

Signed-off-by: Márton Németh <nm127@freemail.hu>
Cc: Julia Lawall <julia@diku.dk>
Cc: cocci@diku.dk
---
diff -u -p a/drivers/serial/8250_hp300.c b/drivers/serial/8250_hp300.c
--- a/drivers/serial/8250_hp300.c 2009-12-03 04:51:21.000000000 +0100
+++ b/drivers/serial/8250_hp300.c 2010-01-08 18:52:23.000000000 +0100
@@ -39,7 +39,7 @@ static int __devinit hpdca_init_one(stru
 					const struct dio_device_id *ent);
 static void __devexit hpdca_remove_one(struct dio_dev *d);

-static struct dio_device_id hpdca_dio_tbl[] = {
+static const struct dio_device_id hpdca_dio_tbl[] = {
 	{ DIO_ID_DCA0 },
 	{ DIO_ID_DCA0REM },
 	{ DIO_ID_DCA1 },

             reply	other threads:[~2010-01-10 16:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-10 16:59 Németh Márton [this message]
2010-01-10 16:59 ` [PATCH 2/3] serial: make dio device id constant Németh Márton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B4A0778.2000508@freemail.hu \
    --to=nm127@freemail.hu \
    --cc=cocci@diku.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.