From: Rik van Riel <riel@redhat.com>
To: Minchan Kim <minchan.kim@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Mel Gorman <mel@csn.ul.ie>, linux-mm <linux-mm@kvack.org>,
lkml <linux-kernel@vger.kernel.org>,
Wu Fengguang <fengguang.wu@intel.com>
Subject: Re: [PATCH v2 -mmotm-2010-01-06-14-34] check high watermark after shrink zone
Date: Sun, 10 Jan 2010 22:46:26 -0500 [thread overview]
Message-ID: <4B4A9F12.8020200@redhat.com> (raw)
In-Reply-To: <20100111084816.81bc7ebd.minchan.kim@barrios-desktop>
On 01/10/2010 06:48 PM, Minchan Kim wrote:
>
>
> * V2
> * Add reviewed-by singed-off (Thanks Kosaki, Wu)
> * Fix typo of changelog
>
> == CUT HERE ==
>
> Kswapd check that zone have enough free by zone_water_mark.
> If any zone doesn't have enough page, it set all_zones_ok to zero.
> !all_zone_ok makes kswapd retry not sleeping.
>
> I think the watermark check before shrink zone is pointless.
> Kswapd try to shrink zone then the check is meaninful.
>
> This patch move the check after shrink zone.
>
> Signed-off-by: Minchan Kim<minchan.kim@gmail.com>
> Reviewed-by: KOSAKI Motohiro<kosaki.motohiro@jp.fujitsu.com>
> Reviewed-by: Wu Fengguang<fengguang.wu@intel.com>
> CC: Mel Gorman<mel@csn.ul.ie>
> CC: Rik van Riel<riel@redhat.com>
Acked-by: Rik van Riel <riel@redhat.com>
--
All rights reversed.
WARNING: multiple messages have this Message-ID (diff)
From: Rik van Riel <riel@redhat.com>
To: Minchan Kim <minchan.kim@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Mel Gorman <mel@csn.ul.ie>, linux-mm <linux-mm@kvack.org>,
lkml <linux-kernel@vger.kernel.org>,
Wu Fengguang <fengguang.wu@intel.com>
Subject: Re: [PATCH v2 -mmotm-2010-01-06-14-34] check high watermark after shrink zone
Date: Sun, 10 Jan 2010 22:46:26 -0500 [thread overview]
Message-ID: <4B4A9F12.8020200@redhat.com> (raw)
In-Reply-To: <20100111084816.81bc7ebd.minchan.kim@barrios-desktop>
On 01/10/2010 06:48 PM, Minchan Kim wrote:
>
>
> * V2
> * Add reviewed-by singed-off (Thanks Kosaki, Wu)
> * Fix typo of changelog
>
> == CUT HERE ==
>
> Kswapd check that zone have enough free by zone_water_mark.
> If any zone doesn't have enough page, it set all_zones_ok to zero.
> !all_zone_ok makes kswapd retry not sleeping.
>
> I think the watermark check before shrink zone is pointless.
> Kswapd try to shrink zone then the check is meaninful.
>
> This patch move the check after shrink zone.
>
> Signed-off-by: Minchan Kim<minchan.kim@gmail.com>
> Reviewed-by: KOSAKI Motohiro<kosaki.motohiro@jp.fujitsu.com>
> Reviewed-by: Wu Fengguang<fengguang.wu@intel.com>
> CC: Mel Gorman<mel@csn.ul.ie>
> CC: Rik van Riel<riel@redhat.com>
Acked-by: Rik van Riel <riel@redhat.com>
--
All rights reversed.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-01-11 3:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-10 23:48 [PATCH v2 -mmotm-2010-01-06-14-34] check high watermark after shrink zone Minchan Kim
2010-01-10 23:48 ` Minchan Kim
2010-01-11 3:46 ` Rik van Riel [this message]
2010-01-11 3:46 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B4A9F12.8020200@redhat.com \
--to=riel@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=minchan.kim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.