From: Kevin Wolf <kwolf@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] dmg: fix ->open failure
Date: Mon, 11 Jan 2010 14:43:59 +0100 [thread overview]
Message-ID: <4B4B2B1F.1090203@redhat.com> (raw)
In-Reply-To: <20100111130654.GA24241@lst.de>
Am 11.01.2010 14:06, schrieb Christoph Hellwig:
>
> Currently the dmg image format driver simply opens the images as raw
> if any kind of failure happens. This is contrarty to the behaviour
> of all other image formats which just return an error and let the
> block core deal with it.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: Kevin Wolf <kwolf@redhat.com>
I mean looking at the patched code I see lots of things that are wrong,
but they are all unrelated to your change: There are error cases where
memory is leaked, and it should use bdrv_* functions instead of the
native open/read/etc. And obviously coding style is completely off (most
annoying: tabs!)
Kevin
next prev parent reply other threads:[~2010-01-11 13:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-11 13:06 [Qemu-devel] [PATCH] dmg: fix ->open failure Christoph Hellwig
2010-01-11 13:43 ` Kevin Wolf [this message]
2010-01-11 13:46 ` Christoph Hellwig
2010-01-11 13:56 ` Kevin Wolf
2010-01-11 14:00 ` Christoph Hellwig
2010-01-11 14:11 ` Kevin Wolf
2010-01-11 17:47 ` Christoph Hellwig
2010-01-12 9:25 ` Kevin Wolf
2010-01-11 19:07 ` malc
2010-01-11 19:51 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B4B2B1F.1090203@redhat.com \
--to=kwolf@redhat.com \
--cc=hch@lst.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.