Re: [Qemu-devel] [PATCH] dmg: fix ->open failure

[Kevin Wolf <kwolf@redhat.com>]

Am 11.01.2010 15:00, schrieb Christoph Hellwig:
> On Mon, Jan 11, 2010 at 02:56:16PM +0100, Kevin Wolf wrote:
>> Are you going to propose a cleaner patch? I have currently some other
>> bugs to do first, but I was certainly planning to do so. However, I'll
>> happily leave it to you if you have the time right now.
> 
> I'm looking into doing it in the generic block layer, yes.

More or less the same hack, just in cleaner? Or trying to fundamentally
change things? I think you haven't answered yet to what I said in the
thread of my original hack. I'm quoting it here for convenience:

> Ok, if you start talking about layering, we can have a fundamental
> discussion on this topic and why the layering is broken anyway.
> Logically, we have image formats like qcow2, VMDK and raw, and they are
> stored in files, on CD-ROMs or general block devices. From a layering
> perspective, it is wrong to include the latter in the raw format driver
> in the first place.

Actually, I think the differentiation between raw files and host_* is at
the same level as protocols are. Probably they should be implemented
very similarly.

Do you think it's possible/worth the effort to try putting things
straight here?

Kevin