From: Boaz Harrosh <bharrosh@panasas.com>
To: Al Viro <viro@ZenIV.linux.org.uk>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Cc: Randy Dunlap <randy.dunlap@oracle.com>
Subject: Re: [PATCH version2] libfs: Open code simple_commit_write into only user
Date: Tue, 12 Jan 2010 15:18:15 +0200 [thread overview]
Message-ID: <4B4C7697.1080806@panasas.com> (raw)
In-Reply-To: <4B4C758B.9040605@panasas.com>
On 01/12/2010 03:13 PM, Boaz Harrosh wrote:
>
> * simple_commit_write was only called by simple_write_end.
> Open coding it makes it tiny bit less heavy on the arithmetic and
> much more readable.
>
> * While at it use zero_user() for clearing a partial page.
> * While at it add a docbook comment for simple_write_end.
>
> Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
> ---
Al should I do the same for simple_prepare_write()?
It is EXPORT_UNUSED_SYMBOL() now, could I remove that
export?
Boaz
next prev parent reply other threads:[~2010-01-12 13:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-30 15:40 [PATCH] libfs: Open code simple_commit_write into only user Boaz Harrosh
2009-12-30 15:57 ` Boaz Harrosh
2009-12-30 17:39 ` Randy Dunlap
2010-01-12 13:13 ` [PATCH version2] " Boaz Harrosh
2010-01-12 13:18 ` Boaz Harrosh [this message]
2010-01-12 13:28 ` Christoph Hellwig
2010-01-12 14:18 ` [PATCH 2/2] libfs: Unexport and kill simple_prepare_write Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B4C7697.1080806@panasas.com \
--to=bharrosh@panasas.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.