Re: Build error: "ENABLE_NLS" is not defined

["Grégoire Sutre" <gregoire.sutre@gmail.com>]

richardvoigt@gmail.com wrote:

> This fix breaks when ENABLE_NLS is defined as 0.

AFAICS, in the implementation of AM_GNU_GETTEXT, ENABLE_NLS is either 
not defined or set to 1.

But I agree that my proposed fix is too dependent on the implementation 
of AM_GNU_GETTEXT, which may change.

Another option would be to replace #if ENABLE_NLS by #if 
defined(ENABLE_NLS) && ENABLE_NLS.

> This gcc bug is blocking a better solution:
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38105

I didn't know that this was a gcc bug.  It felt like a normal behavior 
to me to get an error with both -Wundef and -Werror in that case.  From 
the gcc man page:

  -Werror
      Make all warnings into errors.

  -Wundef
      Warn if an undefined identifier is evaluated in an #if directive.


Grégoire