Re: [PATCH #upstream-fixes] libata: retry link resume if necessary

[Jeff Garzik <jeff@garzik.org>]

On 01/10/2010 09:14 PM, Tejun Heo wrote:
> Interestingly, when SIDPR is used in ata_piix, writes to DET in
> SControl sometimes get ignored leading to detection failure.  Update
> sata_link_resume() such that it reads back SControl after clearing DET
> and retry if it's not clear.
>
> Signed-off-by: Tejun Heo<tj@kernel.org>
> Reported-by: fengxiangjun<fengxiangjun@neusoft.com>
> Reported-by: Jim Faulkner<jfaulkne@ccs.neu.edu>
> Cc: stable@kernel.org
> ---
> Greg, although this patch should be included in -stable release in
> time, I think it should receive some more testing in devel branch for
> at least a couple of -rc cycles as it changes very fundamental part of
> hardreset protocol.  Is there a protocol for delayed inclusion into
> -stable?  If not, I'll try to remember and ping you back after some
> time but I'm almost sure that I'm gonna forget this.  :-)
>
> Thanks.
>
>   drivers/ata/libata-core.c |   38 +++++++++++++++++++++++++++++++-------
>   include/linux/libata.h    |    3 +++
>   2 files changed, 34 insertions(+), 7 deletions(-)

applied