All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Tejun Heo <tj@kernel.org>
Cc: Jeff Garzik <jeff@garzik.org>,
	"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
	fengxiangjun <fengxiangjun@neusoft.com>,
	Jim Faulkner <jfaulkne@ccs.neu.edu>
Subject: Re: [PATCH #upstream-fixes] libata: retry link resume if necessary
Date: Mon, 11 Jan 2010 14:57:26 -0800	[thread overview]
Message-ID: <20100111225726.GA6591@kroah.com> (raw)
In-Reply-To: <4B4A8994.8030600@kernel.org>

On Mon, Jan 11, 2010 at 11:14:44AM +0900, Tejun Heo wrote:
> Interestingly, when SIDPR is used in ata_piix, writes to DET in
> SControl sometimes get ignored leading to detection failure.  Update
> sata_link_resume() such that it reads back SControl after clearing DET
> and retry if it's not clear.
> 
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Reported-by: fengxiangjun <fengxiangjun@neusoft.com>
> Reported-by: Jim Faulkner <jfaulkne@ccs.neu.edu>
> Cc: stable@kernel.org
> ---
> Greg, although this patch should be included in -stable release in
> time, I think it should receive some more testing in devel branch for
> at least a couple of -rc cycles as it changes very fundamental part of
> hardreset protocol.  Is there a protocol for delayed inclusion into
> -stable?  If not, I'll try to remember and ping you back after some
> time but I'm almost sure that I'm gonna forget this.  :-)

I'll drop this into my "todo-stable" queue, and ping you back on this in
a few weeks.  Sound good?

thanks,

greg k-h

  reply	other threads:[~2010-01-11 22:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-11  2:14 [PATCH #upstream-fixes] libata: retry link resume if necessary Tejun Heo
2010-01-11 22:57 ` Greg KH [this message]
2010-01-12  5:00   ` Tejun Heo
2010-01-12 19:38 ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100111225726.GA6591@kroah.com \
    --to=greg@kroah.com \
    --cc=fengxiangjun@neusoft.com \
    --cc=jeff@garzik.org \
    --cc=jfaulkne@ccs.neu.edu \
    --cc=linux-ide@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.