All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Mahoney <jeffm@suse.com>
To: David Rientjes <rientjes@google.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux-MM <linux-mm@kvack.org>,
	Lee Schermerhorn <Lee.Schermerhorn@hp.com>
Subject: [patch] hugetlb: Fix section mismatches #2
Date: Wed, 13 Jan 2010 10:03:29 -0500	[thread overview]
Message-ID: <4B4DE0C1.7080709@suse.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1001130127450.469@chino.kir.corp.google.com>

 hugetlb_register_node calls hugetlb_sysfs_add_hstate, which is marked with
 __init. Since hugetlb_register_node is only called by
 hugetlb_register_all_nodes, which in turn is only called by hugetlb_init,
 it's safe to mark both of them as __init.

Signed-off-by: Jeff Mahoney <jeffm@suse.com>
---
 mm/hugetlb.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -1650,7 +1650,7 @@ static void hugetlb_unregister_all_nodes
  * Register hstate attributes for a single node sysdev.
  * No-op if attributes already registered.
  */
-void hugetlb_register_node(struct node *node)
+void __init hugetlb_register_node(struct node *node)
 {
 	struct hstate *h;
 	struct node_hstate *nhs = &node_hstates[node->sysdev.id];
@@ -1683,7 +1683,7 @@ void hugetlb_register_node(struct node *
  * sysdevs of nodes that have memory.  All on-line nodes should have
  * registered their associated sysdev by this time.
  */
-static void hugetlb_register_all_nodes(void)
+static void __init hugetlb_register_all_nodes(void)
 {
 	int nid;
 
-- 
Jeff Mahoney
SUSE Labs

WARNING: multiple messages have this Message-ID (diff)
From: Jeff Mahoney <jeffm@suse.com>
To: David Rientjes <rientjes@google.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux-MM <linux-mm@kvack.org>,
	Lee Schermerhorn <Lee.Schermerhorn@hp.com>
Subject: [patch] hugetlb: Fix section mismatches #2
Date: Wed, 13 Jan 2010 10:03:29 -0500	[thread overview]
Message-ID: <4B4DE0C1.7080709@suse.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1001130127450.469@chino.kir.corp.google.com>

 hugetlb_register_node calls hugetlb_sysfs_add_hstate, which is marked with
 __init. Since hugetlb_register_node is only called by
 hugetlb_register_all_nodes, which in turn is only called by hugetlb_init,
 it's safe to mark both of them as __init.

Signed-off-by: Jeff Mahoney <jeffm@suse.com>
---
 mm/hugetlb.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -1650,7 +1650,7 @@ static void hugetlb_unregister_all_nodes
  * Register hstate attributes for a single node sysdev.
  * No-op if attributes already registered.
  */
-void hugetlb_register_node(struct node *node)
+void __init hugetlb_register_node(struct node *node)
 {
 	struct hstate *h;
 	struct node_hstate *nhs = &node_hstates[node->sysdev.id];
@@ -1683,7 +1683,7 @@ void hugetlb_register_node(struct node *
  * sysdevs of nodes that have memory.  All on-line nodes should have
  * registered their associated sysdev by this time.
  */
-static void hugetlb_register_all_nodes(void)
+static void __init hugetlb_register_all_nodes(void)
 {
 	int nid;
 
-- 
Jeff Mahoney
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2010-01-13 15:04 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-13  0:48 [patch 0/6] Section mismatch fixes Jeff Mahoney
2010-01-13  0:48 ` [patch 2/6] hugetlb: Fix section mismatches Jeff Mahoney
2010-01-13  0:48   ` Jeff Mahoney
2010-01-13  9:28   ` David Rientjes
2010-01-13  9:28     ` David Rientjes
2010-01-13 14:29     ` Jeff Mahoney
2010-01-13 14:29       ` Jeff Mahoney
2010-01-13 15:03     ` Jeff Mahoney [this message]
2010-01-13 15:03       ` [patch] hugetlb: Fix section mismatches #2 Jeff Mahoney
2010-01-13 20:51       ` David Rientjes
2010-01-13 20:51         ` David Rientjes
2010-01-13 15:40   ` [patch 2/6] hugetlb: Fix section mismatches Lee Schermerhorn
2010-01-13 15:40     ` Lee Schermerhorn
2010-01-13 15:42     ` Jeff Mahoney
2010-01-13 15:42       ` Jeff Mahoney
2010-01-13  0:48 ` [patch 4/6] acpi: Fix section mismatch Jeff Mahoney
2010-01-13  3:58   ` Alex Chiang
2010-01-13  0:49 ` [patch 6/6] virtio: fix section mismatch warnings Jeff Mahoney
2010-01-13 10:57   ` Rusty Russell
2010-01-14  1:07     ` Andrew Morton
2010-01-14  2:01       ` Jeff Mahoney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B4DE0C1.7080709@suse.com \
    --to=jeffm@suse.com \
    --cc=Lee.Schermerhorn@hp.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.