From: Jeff Garzik <jeff@garzik.org>
To: Pete Zaitcev <zaitcev@redhat.com>, Colin McCabe <cmccabe@alumni.cmu.edu>
Cc: Project Hail List <hail-devel@vger.kernel.org>
Subject: Re: [PATCH] cld: use XDR for all messages
Date: Wed, 13 Jan 2010 17:16:24 -0500 [thread overview]
Message-ID: <4B4E4638.5020305@garzik.org> (raw)
In-Reply-To: <20100113143809.1c3d4600@redhat.com>
On 01/13/2010 04:38 PM, Pete Zaitcev wrote:
> On Wed, 13 Jan 2010 16:03:45 -0500
> Jeff Garzik<jeff@garzik.org> wrote:
>
>> Well, this definitely does not build as-is. lib/Makefile.am needs
>>
>> BUILT_SOURCES = cld_msg_rpc.h
>>
>> otherwise nothing builds at all, because cld_msg_rpc.h does not exist.
>> test/Makefile.am and tools/Makefile.am both need
>>
>> -I$(top_srcdir)/lib
>>
>> added to their INCLUDES. []
>
> Kernel places generated files into the top include directory,
> e.g. autoconf.h and asm-offsets.h for asm/. It's probably easier
> than piling up include paths. I dunno.
Anything other than $(top_srcdir)/include requires an addition to
INCLUDES. (remember, build-dir != src-dir always, especially with 'make
distcheck')
Speaking of 'make distcheck', that is broken in the XDR patch, too.
include/Makefile.am needs cld_fmt.h added to include_HEADERS.
Jeff
next prev parent reply other threads:[~2010-01-13 22:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-10 15:00 [PATCH] cld: use XDR for all messages Colin McCabe
2010-01-11 13:28 ` Jeff Garzik
2010-01-13 21:03 ` Jeff Garzik
2010-01-13 21:38 ` Pete Zaitcev
2010-01-13 22:16 ` Jeff Garzik [this message]
2010-01-14 0:10 ` Jeff Garzik
2010-01-14 6:35 ` Colin McCabe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B4E4638.5020305@garzik.org \
--to=jeff@garzik.org \
--cc=cmccabe@alumni.cmu.edu \
--cc=hail-devel@vger.kernel.org \
--cc=zaitcev@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.