From: "H. Peter Anvin" <hpa@zytor.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Yinghai Lu <yinghai@kernel.org>,
Suresh Siddha <suresh.b.siddha@intel.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
"ananth@in.ibm.com" <ananth@in.ibm.com>,
Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -v2 5/5] x86: use dmi check to treat disabled cpus as hotplug cpus.
Date: Wed, 13 Jan 2010 14:27:07 -0800 [thread overview]
Message-ID: <4B4E48BB.5030902@zytor.com> (raw)
In-Reply-To: <20100113222348.GE24818@basil.fritz.box>
On 01/13/2010 02:23 PM, Andi Kleen wrote:
>> There are configurations in which percpu memory is in the megabytes.
>
> There used to be some like this (with some broken debug code), but they
> got all fixed i believe to only allocate on real cpu hotplug.
>
> If not the right way is to fix them, not add DMI blacklists.
>
> Beside when you enable debug code you probably don't care about
> a few MB too much.
>
>> This is exactly why we need high water mark allocation of percpu memory:
>
> No we just need to fix any percpu pigs (if there are really any left,
> I did a couple of patches some time ago)
>
> "Don't work around broken code -- fix it"
>
Well, that *is* working around broken code, in this case the broken code
is the percpu allocation strategy.
-hpa
next prev parent reply other threads:[~2010-01-13 22:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-12 23:17 [PATCH 0/5] clean up logical flat apic mode using Yinghai Lu
2010-01-12 23:17 ` [PATCH -v2 1/5] use nr_cpus= to set nr_cpu_ids early Yinghai Lu
2010-01-12 23:17 ` [PATCH 2/5] x86: using logical flat for amd cpu too Yinghai Lu
2010-01-12 23:17 ` [PATCH -v2 3/5] x86: according to nr_cpu_ids to decide if need to leave logical flat Yinghai Lu
2010-01-12 23:17 ` [PATCH -v2 5/5] x86: use dmi check to treat disabled cpus as hotplug cpus Yinghai Lu
2010-01-12 23:56 ` Suresh Siddha
2010-01-13 0:05 ` Yinghai Lu
2010-01-13 1:48 ` Suresh Siddha
2010-01-13 1:55 ` Yinghai Lu
2010-01-13 2:06 ` Suresh Siddha
2010-01-13 2:13 ` Yinghai Lu
2010-01-13 2:21 ` Suresh Siddha
2010-01-13 2:26 ` Yinghai Lu
2010-01-13 21:46 ` Andi Kleen
2010-01-13 22:00 ` H. Peter Anvin
2010-01-13 22:23 ` Andi Kleen
2010-01-13 22:27 ` H. Peter Anvin [this message]
2010-01-13 22:29 ` Suresh Siddha
2010-01-13 22:36 ` H. Peter Anvin
2010-01-13 22:49 ` Suresh Siddha
2010-01-13 23:02 ` Yinghai Lu
2010-01-13 23:13 ` H. Peter Anvin
2010-01-13 23:52 ` Andi Kleen
2010-01-14 9:25 ` Andi Kleen
2010-01-12 23:17 ` [PATCH 4/5] x86: make 32bit apic flat to physflat switch like 64bit Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B4E48BB.5030902@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=ananth@in.ibm.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.