From: Jan Kiszka <jan.kiszka@siemens.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Gerd Hoffmann <kraxel@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH][STABLE] Don't set default monitor when there is a mux'ed one
Date: Thu, 14 Jan 2010 16:19:52 +0100 [thread overview]
Message-ID: <4B4F3618.3020103@siemens.com> (raw)
In-Reply-To: <4B4F3343.1030809@codemonkey.ws>
Anthony Liguori wrote:
> On 01/14/2010 08:49 AM, Jan Kiszka wrote:
>> This fixes eg. "-nographic -serial mon:stdio [-serial ...]".
>>
>
> Is this really an appropriate invocation though?
>
> -nographic != mon:stdio so the semantics of how this is supposed to
> behave is at best ill-defined.
Original -nographic implied mon:stdio unless you specified your own
-serial. If this was reasonable or not, changing behavior now breaks
tons of scripts.
Actually, there is more legacy breakage in the new default handling. The
missing translation of "-serial stdio -monitor stdio" => "-serial
mon:stdio" can already be harmful to some setups, though I guess they
are less common.
However, this patch addresses something that is a bug outside the scope
of -nographic's semantic.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
prev parent reply other threads:[~2010-01-14 15:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-14 14:49 [Qemu-devel] [PATCH][STABLE] Don't set default monitor when there is a mux'ed one Jan Kiszka
2010-01-14 14:58 ` [Qemu-devel] " Gerd Hoffmann
2010-01-14 15:07 ` [Qemu-devel] " Anthony Liguori
2010-01-14 15:19 ` Jan Kiszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B4F3618.3020103@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=aliguori@us.ibm.com \
--cc=anthony@codemonkey.ws \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.