All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@redhat.com>
To: "Aneesh Kumar K. V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: cmm@us.ibm.com, tytso@mit.edu, linux-ext4@vger.kernel.org
Subject: Re: [PATCH -V2] ext4: unmap the underlying metadata when allocating blocks via fallocate
Date: Thu, 14 Jan 2010 13:31:56 -0600	[thread overview]
Message-ID: <4B4F712C.3070902@redhat.com> (raw)
In-Reply-To: <87wrzklesd.fsf@linux.vnet.ibm.com>

Aneesh Kumar K. V wrote:
> On Thu, 14 Jan 2010 11:00:39 -0600, Eric Sandeen <sandeen@redhat.com> wrote:
>> Aneesh Kumar K.V wrote:
>>> This become important when we are running with nojournal mode. We
>>> may end up allocating recently freed metablocks for fallocate. We
>>> want to make sure we unmap the old mapping so that when we convert
>>> the fallocated uninitialized extent to initialized extent we don't
>>> have the old mapping around. Leaving the old mapping can cause
>>> file system corruption
>>>
>>> Now that we unmap old metadata blocks we need not return blocks
>>> allocated from fallocate area as new.
>> With this, unmap_underlying_metadata_blocks is no longer used
>> and can be removed I guess.
>>
> 
> Yes. Updated patch below

Ok, with the latest versions of these 3 patches, fsstress / 013
is working here, modulo the blocks-past-eof-from-fallocate problem
that remains.

Thanks,
-Eric

  reply	other threads:[~2010-01-14 19:32 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-06 19:22 [PATCH 1/3] ext4: Fix quota accounting error with fallocate Aneesh Kumar K.V
2010-01-06 19:22 ` [PATCH 2/3] ext4: Drop EXT4_GET_BLOCKS_UPDATE_RESERVE_SPACE flag Aneesh Kumar K.V
2010-01-06 19:50   ` Mingming
2010-01-06 19:22 ` [PATCH 3/3] ext4: unmap the underlying metadata when allocating blocks via fallocate Aneesh Kumar K.V
2010-01-06 20:20   ` Eric Sandeen
2010-01-14 17:00   ` Eric Sandeen
2010-01-14 18:30     ` [PATCH -V2] " Aneesh Kumar K. V
2010-01-14 19:31       ` Eric Sandeen [this message]
2010-01-24 18:24       ` tytso
2010-01-25  5:12         ` Aneesh Kumar K. V
2010-01-25  9:02           ` tytso
2010-01-25 15:43             ` Eric Sandeen
2010-01-25 17:55               ` tytso
2010-01-25 18:21                 ` Aneesh Kumar K. V
2010-01-06 19:47 ` [PATCH 1/3] ext4: Fix quota accounting error with fallocate Mingming
2010-01-13 14:55 ` [PATCH -V2] " Aneesh Kumar K.V

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B4F712C.3070902@redhat.com \
    --to=sandeen@redhat.com \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=cmm@us.ibm.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.