From: Sunil Mushran <sunil.mushran@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 2/3] ocfs2:freeze-thaw: initialization and cleanup
Date: Thu, 14 Jan 2010 18:36:11 -0800 [thread overview]
Message-ID: <4B4FD49B.6040809@oracle.com> (raw)
In-Reply-To: <20100115022628.GB3760@laptop.oracle.com>
Wengang Wang wrote:
> if you meant ocfs2_freeze_unlock() in ocfs2_umount_volume() instead of
> at the end of ocfs2_mount_volume(), it's NG.
> if cleanup when umount, then we always have a ro_holder, freeze/thaw
> doesn't work.
>
> and we dont need to clean it up in umount if we already cleanup it in
> mount_volume. this is because the lock/unlock is used in pairs.
>
What's NG?
And I am not following you. Don't we have to free all locks during
umount?
next prev parent reply other threads:[~2010-01-15 2:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-09 18:00 [Ocfs2-devel] [PATCH 2/3] ocfs2:freeze-thaw: initialization and cleanup Wengang Wang
2010-01-15 1:53 ` Sunil Mushran
2010-01-15 2:26 ` Wengang Wang
2010-01-15 2:36 ` Sunil Mushran [this message]
2010-01-15 2:41 ` Wengang Wang
2010-01-15 21:36 ` Sunil Mushran
2010-01-17 8:52 ` Wengang Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B4FD49B.6040809@oracle.com \
--to=sunil.mushran@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.